Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vorbis is fully supported since Safari 16.0 #6946

Closed
wants to merge 2 commits into from

Conversation

jensimmons
Copy link
Contributor

Ogg Vorbis is fully supported on macOS 11.3 Big Sur or later. Safari 16.0 also requires Big Sur or later. Therefore, Ogg Vorbis should be marked "fully supported" since Safari 16.0. I also updated the note to be clearer about support.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Ogg Vorbis is fully supported on macOS 11.3 Big Sur or later. Safari 16.0 also requires Big Sur or later. Therefore, Ogg Vorbis should be marked "fully supported" since Safari 16.0. I also updated the note to be clearer about support.
@jensimmons
Copy link
Contributor Author

Any clue as to why the tests failed?

@Fyrd
Copy link
Owner

Fyrd commented Jan 25, 2024

Any clue as to why the tests failed?

Looks like there's an uppercase Y that's causing the failure.

I notice the description change removes the part in the description that mentions that the ogg container format is not supported, which I imagine was at least the case when support was added (see #5875). If support was added for it since then do we know in which version?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixing "Y" and resetting note back to original version.
@jensimmons
Copy link
Contributor Author

I fixed the "Y". And look a deeper look at the note. I'm not sure what the answer is to your question, so I reverted the note back to its current state. We can update that later if needed. Meanwhile, full support was added in Safari 16.0 and the PR now corrects that.

@Fyrd
Copy link
Owner

Fyrd commented Feb 5, 2024

I just tested at https://tests.caniuse.com/?feat=ogg-vorbis using Safari 16.4 and it didn't seem to work. Also tried files from https://getsamplefiles.com/sample-audio-files/ogg and they failed as well. Is there a test you know of that works?

@jensimmons
Copy link
Contributor Author

jensimmons commented Feb 28, 2024

What I understand now is that Ogg and Vorbis are two different features.
Vorbis is an audio codec that is supported in Safari 14.1+ on Mac and Safari 17.4+ on iOS, iPadOS, and visionOS.
And Ogg is a media container format that is not currently supported in Safari.

One option would be to split this page into two features, since they aren't necessarily required to go together. The Vorbis codec, for example is used in WebM containers.

Meanwhile, I created a different PR with the assumption that the page will remain as is, one page for two features, updating Safari's support for Vorbis with newer information.

@jensimmons jensimmons changed the title Ogg Vorbis "fully supported" since Safari 16.0 Vorbis is fully supported since Safari 16.0 Feb 28, 2024
@jensimmons jensimmons closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants