Unify usage of coroutine scope across project #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsogtb
previously requested changes
May 2, 2024
app/src/main/java/ch/epfl/cs311/wanderwave/model/auth/AuthenticationController.kt
Outdated
Show resolved
Hide resolved
IB-12
approved these changes
May 2, 2024
yzueger
force-pushed
the
bugfix/unify-coroutine-scopes
branch
from
2600f7c to
e7d5589
Compare
aymanbakiri
approved these changes
May 2, 2024
There was a problem hiding this comment.
Thanks for updating the coroutine scope usage in our project. Now, everything can be called from a viewModel coroutine scope. You have also corrected the issue of manually setting the dispatchers by injecting dispatchers instead. I think you only need to increase the coverage and it will be ready to merge. Thanks for your good work.
|
KlaKalma
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208
The refactors the coroutine scope usage so that basically everything is callable from a viewmodel coroutine scope. Only in the actual model implementations of repositories that directly talk to a database/webserver or something we switch to the IO sope using
withContext(Dispatchers.IO) {}