Feature/link profile to auth/main #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uth/persist-profile Feature/link profile to auth/persist profile
KlaKalma
reviewed
May 19, 2024
| @@ -26,14 +26,11 @@ class ProfileConnection( | |||
| override val db = database | |||
| private val coroutineScope = CoroutineScope(Dispatchers.IO + SupervisorJob()) | |||
|
|
|||
| override fun isUidExisting(spotifyUid: String, callback: (Boolean, Profile?) -> Unit) { | |||
| override fun isUidExisting(firebaseUid: String, callback: (Boolean, Profile?) -> Unit) { | |||
There was a problem hiding this comment.
As we said that both are the same we should probably do a refactoring of it soon where we have only one uid no ? And delete the spotify UID. Of course not for this PR
| viewModelScope.launch { | ||
| repository.getItem(id).collect { fetchedProfile -> | ||
| suspend fun getProfileByID(id: String, create: Boolean) { | ||
| repository.isUidExisting(id) { exists, fetchedProfile -> |
There was a problem hiding this comment.
You probably should use getItem instead of isUidExisting
…uth/merge-main Feature/link profile to auth/merge main
…uth/set-user-profile-in-track-association Feature/link profile to auth/set user profile in track association
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262
Feature branch merge