Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug #348

Merged
merged 2 commits into from
May 19, 2024
Merged

Fix a bug #348

merged 2 commits into from
May 19, 2024

Conversation

mbouaissi
Copy link
Collaborator

Fix a bug that was fix before but lost during a merge

@mbouaissi mbouaissi marked this pull request as ready for review May 19, 2024 14:01
Copy link
Collaborator

@yzueger yzueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Copy link
Collaborator

@IB-12 IB-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a pretty straightforward fix, well done on getting 100% coverage. LGTM

@@ -220,6 +220,12 @@ fun handleItemClick(
viewModel.retrieveChild(listItem)
return
}
if (listItem.id.contains("spotify:") ||
listItem.id.isBlank()) { // TODO: create an issue for handling this
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to create this issue if you haven't already done so

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes chef

@IB-12 IB-12 merged commit e95a829 into main May 19, 2024
2 checks passed
@IB-12 IB-12 deleted the fix-bug-spotify branch May 19, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants