Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm packages #49

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update npm packages #49

wants to merge 2 commits into from

Conversation

stefeiner
Copy link
Contributor

  • removed unused npm packages
  • updated npm packages
  • configured eslint:
    • replaced .eslintrc.json with eslint.config.js
    • added "type": "module" in package.json
  • configured jest:
    • replaced "test": "react-app-rewired test" with "test": "jest" in package.json
    • add scripts for watch and coverage in package.json
    • added configuration files jest.config.json and babel.config.json as well as src/__mocks__/fileMock.js, src/__mocks__/styleMock.js and src/setupTests.ts
  • Due to the eslint changes in package.json it was necessary to add the file extentions to imports in a lot of files
  • While running the application: In the console there warnings like in the screenshot. To solve this warnings it was necessary to add $ to props like in this answer on stackoverflow.

warning-in-console

  • if you use npm i there is still a warning. This is caused by the package react-plotly.js which has an outdated dependency. There is an open issue in the plotly repo.

closes issue #48

closes issue #48

Signed-off-by: Stefanie Schreiner <stefanie.schreiner@msg.group>
closes issue #48

Signed-off-by: Stefanie Schreiner <stefanie.schreiner@msg.group>
@devbysp
Copy link
Contributor

devbysp commented Sep 27, 2024

Task

Notes

Updating the jest is obsolate. It has already been done in this pull request:

Within this task:

It can not be merged in this state it conflicts with the current implementation of enabling jest configuration.

@devbysp devbysp mentioned this pull request Sep 27, 2024
@lenasauermann lenasauermann requested review from robertschubert and removed request for bajaioana October 11, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants