Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Remove deprecated user.pools field #7664

Closed
3 tasks
mnigh opened this issue Aug 18, 2023 · 0 comments · Fixed by #8251
Closed
3 tasks

♻️ Remove deprecated user.pools field #7664

mnigh opened this issue Aug 18, 2023 · 0 comments · Fixed by #8251
Assignees
@vd1992
Labels
debt Refactor or improve existing code.

Comments

@mnigh
Copy link
Contributor

mnigh commented Aug 18, 2023 •
edited by petertgiles
Loading

♻️ Debt/Refactor

This field is deprecated.

gc-digital-talent/api/graphql/schema.graphql

Lines 136 to 139 in 4000aac

pools: [Pool]
@hasMany
@can(ability: "view", resolved: true)
@deprecated(reason: "pools is deprecated. User.roles.team.pools instead.") # Pools a user owns

✅ Acceptance Criteria

A set of assumptions which, when tested, verify that the debt was addressed and expected functionality has not been affected.

  • user.pools field removed from schema file
  • References to this field have been removed or replaced
  • There may be some code changes required to complete this
@mnigh mnigh added the debt Refactor or improve existing code. label Aug 18, 2023
@vd1992 vd1992 self-assigned this Oct 18, 2023
@vd1992 vd1992 mentioned this issue Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vd1992 vd1992

Labels
debt Refactor or improve existing code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Debt] Remove deprecated 'users.pools' GCTC-NTGC/gc-digital-talent
2 participants
@mnigh @vd1992