[Debt] Remove deprecated 'users.pools' #8251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vd1992
commented
Oct 18, 2023
Comment on lines
48
to
-54
| const generateUser = ( | ||
| departments: Department[], | ||
| classifications: Classification[], // all classifications | ||
| genericJobTitles: GenericJobTitle[], // all generic job titles |
There was a problem hiding this comment.
While looking at fakeUsers.ts I noticed this was unused and didn't actually get used in the function return.
Probably left floating around after #8000
There was a problem hiding this comment.
Are we not using genericJobTitle at all anymore? I noticed a lot of unused refs to it while converting tests to TS.
There was a problem hiding this comment.
Pretty much, ya, #7578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #7664
👋 Introduction
Remove the deprecated field.
🕵️ Details
Wasn't actually used/referenced anywhere I could find other than the faker file.
🧪 Testing