[Debt] Remove deprecated 'users.pools' (#8251)

* remove deprecated field * remove user.pools field * remove unused genericJobTitles
GCTC-NTGC · Oct 19, 2023 · ba70347 · ba70347
1 parent 24ca54e
commit ba70347
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/api/graphql/schema.graphql b/api/graphql/schema.graphql
@@ -119,13 +119,6 @@ type User {
   topBehaviouralSkillsRanking: [UserSkill]
   improveTechnicalSkillsRanking: [UserSkill]
   improveBehaviouralSkillsRanking: [UserSkill]
-  # Pool Manager info
-  pools: [Pool]
-    @hasMany
-    @can(ability: "view", resolved: true)
-    @deprecated(
-      reason: "pools is deprecated. user.roles.team.pools instead. Remove in #7664."
-    ) # Pools a user owns
   # Profile Status
   isProfileComplete: Boolean
   priorityWeight: Int @rename(attribute: "priority_weight")

diff --git a/api/storage/app/lighthouse-schema.graphql b/api/storage/app/lighthouse-schema.graphql
@@ -229,7 +229,6 @@ type User {
   topBehaviouralSkillsRanking: [UserSkill]
   improveTechnicalSkillsRanking: [UserSkill]
   improveBehaviouralSkillsRanking: [UserSkill]
-  pools: [Pool] @deprecated(reason: "pools is deprecated. user.roles.team.pools instead. Remove in #7664.")
   isProfileComplete: Boolean
   priorityWeight: Int
   roleAssignments: [RoleAssignment!]

diff --git a/packages/fake-data/src/fakeUsers.ts b/packages/fake-data/src/fakeUsers.ts
@@ -10,13 +10,11 @@ import {
   EstimatedLanguageAbility,
   Classification,
   OperationalRequirement,
-  Pool,
   WorkRegion,
   GovEmployeeType,
   Department,
   CitizenshipStatus,
   ArmedForcesStatus,
-  GenericJobTitle,
   PositionDuration,
   IndigenousCommunity,
   Maybe,
@@ -31,7 +29,6 @@ import {
 } from "./fakeExperiences";
 import fakeClassifications from "./fakeClassifications";
 import fakeDepartments from "./fakeDepartments";
-import fakeGenericJobTitles from "./fakeGenericJobTitles";
 import { GeneratedPoolCandidate } from "./fakePoolCandidateTypes";
 
 type GeneratedUser = User & {
@@ -51,7 +48,6 @@ type GeneratedUser = User & {
 const generateUser = (
   departments: Department[],
   classifications: Classification[], // all classifications
-  genericJobTitles: GenericJobTitle[], // all generic job titles
 
   awardExperiences: GeneratedAwardExperience[], // Experiences belonging to this user
   communityExperiences: GeneratedCommunityExperience[], // Experiences belonging to this user
@@ -60,7 +56,6 @@ const generateUser = (
   workExperiences: GeneratedWorkExperience[], // Experiences belonging to this user
 
   poolCandidates: GeneratedPoolCandidate[] = [], // poolCandidates associating this user with a pool
-  pools: Pool[] = [], // pools owned by this user
 ): GeneratedUser => {
   return {
     __typename: "User",
@@ -173,16 +168,13 @@ const generateUser = (
     educationExperiences,
     personalExperiences,
     workExperiences,
-
-    pools,
   };
 };
 
 // Default generator will not include any experiences, poolCandidates or pools
 const defaultGenerator = (numToGenerate = 20): GeneratedUser[] => {
   const departments = fakeDepartments();
   const classifications = fakeClassifications();
-  const genericJobTitles = fakeGenericJobTitles();
 
   const awardExperiences: GeneratedAwardExperience[] = [];
   const communityExperiences: GeneratedCommunityExperience[] = [];
@@ -195,7 +187,6 @@ const defaultGenerator = (numToGenerate = 20): GeneratedUser[] => {
     generateUser(
       departments,
       classifications,
-      genericJobTitles,
       awardExperiences,
       communityExperiences,
       educationExperiences,