Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debt] Removes expectedClassifications, expectedSalary, expectedGenericJobTitle #7578

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Aug 10, 2023

πŸ€– Resolves #5347.

πŸ‘‹ Introduction

This PR removes the expectedClassifications, expectedSalary, and expectedGenericJobTitle from the application and deprecates the fields in the API.

πŸ•΅οΈ Details

We no longer use these anywhere in the application so they are now redundant.

Note
Some references were left for compatibility reasons.

🎩 Acknowledgements

πŸ‘ @esizer, @yonikid15 for past work used as a reference.

πŸ§ͺ Testing

  1. Run refresh_api.sh
  2. Build frontend
    1. npm run codegen
    2. npm run dev
  3. Navigate to /admin/users
    1. Confirm classifications are gone from filters
    2. Confirm role and salary does not exist on view users
    3. Print a user and confirm expected role and salary does not appear
    4. Export CSV and confirm expected role and salary does not appear
  4. Navigate to /users/:used-id/profile
    1. Confirm role and salary section does not appear
    2. Confirm you can still complete your profile
  5. Create an application
    1. Confirm role and salary section does not appear
    2. Confirm you can complete the application with no role and salary expectations
  6. Ensure no references to expectedClassifications, expectedSalary, expectedGenericJobTitle (other than deprecated ones in graphql schema)

Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! πŸ‘

api/database/seeders/DatabaseSeeder.php Outdated Show resolved Hide resolved
@mnigh mnigh merged commit 8c6bb77 into main Aug 14, 2023
9 checks passed
@mnigh mnigh deleted the 5347-remove-roles-salaries branch August 14, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Remove Roles and Salaries section of profile
3 participants