Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Handle multiple spaces in text search #10444

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented May 22, 2024

🤖 Resolves #10384

👋 Introduction

Handle multiple spaces being present in search string like "a or b"
Added a test function to the search test file.

🧪 Testing

  1. Navigate to /en/admin/pool-candidates
  2. Exercise searching with multiple spaces

📸 Screenshot

image

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.16%. Comparing base (0f6d236) to head (93050c7).

Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10444       +/-   ##
=============================================
+ Coverage     38.64%   71.16%   +32.51%     
  Complexity     1416     1416               
=============================================
  Files           996      219      -777     
  Lines         30586     5462    -25124     
  Branches       6557        0     -6557     
=============================================
- Hits          11820     3887     -7933     
+ Misses        18733     1575    -17158     
+ Partials         33        0       -33     
Flag Coverage Δ
integrationtests 71.16% <100.00%> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brindasasi brindasasi self-requested a review May 23, 2024 14:36
@brindasasi
Copy link
Contributor

I get time out when I combine 2 terms. Single words work fine :(
Screenshot 2024-05-23 at 2 43 09 PM
Screenshot 2024-05-23 at 2 48 04 PM
Screenshot 2024-05-23 at 2 38 32 PM

@brindasasi
Copy link
Contributor

brindasasi commented May 23, 2024

Screenshot 2024-05-23 at 2 54 20 PM
If its not reproducible for you , we can verify it in dev. If its working there , then it could be my local being slow.
But single search term brings out the results very swiftly makes me suspicious.
Let me know if you need help deploying in dev

Edit: Looks like it works fine with 10 records page limit. It just doesn't work for me in 20 records per page limit.

@vd1992
Copy link
Contributor Author

vd1992 commented May 23, 2024

If its not reproducible for you , we can verify it in dev. If its working there , then it could be my local being slow. But single search term brings out the results very swiftly makes me suspicious. Let me know if you need help deploying in dev

No, I can't seem to replicate that issue/error 😕
Do you want to deploy it or wait for someone else to try it out?

@brindasasi
Copy link
Contributor

If its not reproducible for you , we can verify it in dev. If its working there , then it could be my local being slow. But single search term brings out the results very swiftly makes me suspicious. Let me know if you need help deploying in dev

No, I can't seem to replicate that issue/error 😕 Do you want to deploy it or wait for someone else to try it out?

yeah I can deploy it in dev

Copy link
Contributor

@brindasasi brindasasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works just fine in dev 😌
I hate my local 😭

@vd1992
Copy link
Contributor Author

vd1992 commented May 23, 2024

works just fine in dev 😌 I hate my local 😭

Crowdfund a new PC for you and @yonikid15 💸

@vd1992 vd1992 added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit ace1409 May 23, 2024
8 checks passed
@vd1992 vd1992 deleted the 10384-multi-space-text-search branch May 23, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Multiple spaces between search terms breaks User general search
3 participants