Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debt] Bumps ts-jest #11803

Closed
wants to merge 6 commits into from
Closed

[Debt] Bumps ts-jest #11803

wants to merge 6 commits into from

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Oct 21, 2024

🤖 Resolves #11364.

👋 Introduction

This PR bumps the version of ts-jest to its latest version and updates a file path for it to work.

🧪 Testing

  1. cd apps/web
  2. pnpm test -- lang.test.ts
  3. Verify test passes

@petertgiles
Copy link
Contributor

I don't love this solution, tbh. Maybe adding the i18n package to the devDependencies would do the trick?

@mnigh
Copy link
Contributor Author

mnigh commented Oct 22, 2024

I don't love this solution, tbh. Maybe adding the i18n package to the devDependencies would do the trick?

I like your solution, but it doesn't seem to work in CI (it does locally though). Thoughts?

@petertgiles
Copy link
Contributor

It doesn't work locally for me. Maybe you need to clean your workspace and rebuild to replicate?

Anyway, I think the issue is that the files are not exported in the package index file. This works for me:

image

I'm a little worried about that reusing the existing fr import/export. As far as I can tell, it's not being used anywhere, though.

@petertgiles
Copy link
Contributor

I posted my suggested fix

@petertgiles
Copy link
Contributor

... and it didn't work. 😆

@mnigh
Copy link
Contributor Author

mnigh commented Oct 24, 2024

... and it didn't work. 😆

If I revert to my original solution, would that be acceptable?

@petertgiles
Copy link
Contributor

I don't really like it - it seems like a hack. I think this patch version bump is not so urgent that we need to resort to that yet.

@mnigh mnigh closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Bump ts-jest from 29.2.3 to 29.2.5 (Or latest)
2 participants