-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Admin view and edit work email #11813
Conversation
Wow, this works really well. I'm worried about adding "is gov employee" to this page though. There are some side-effects to this setup:
Given that this form is design to be used by an admin during troubleshooting, not the end user, I'd prefer a simple form without the extra validation. |
I see what you're saying @petertgiles, Admins will have a more powerful, flexible tool if we allow for a disconnect between these two fields. The other things I want to suggest is removing |
🤦 I'm not sure how I didn't consider that. Thoughts on these changes? The only requirement for updating work email as an admin now is email domain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks great!
🤖 Resolves #11740.
👋 Introduction
Adds the work email and government employee (after some discussion with @Jerryescandon) fields to the users table and admin edit user pages.
🧪 Testing
/admin/users
📸 Screenshot