Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Training fund page #11821

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[FEATURE] Training fund page #11821

wants to merge 19 commits into from

Conversation

petertgiles
Copy link
Contributor

@petertgiles petertgiles commented Oct 23, 2024

πŸ€– Resolves #11794, #11799

πŸ‘‹ Introduction

Adds the new IT training fund page.

πŸ•΅οΈ Details

I noticed our heading component doesn't wrap how it should in designs, especially in mobile widths. I can open an issue for that.

πŸ§ͺ Testing

  1. Rebuild the site
  2. Navigate to /en/it-training-fund
  • Content correct
    • en
    • fr
  • Matches design
    • desktop
    • mobile
  • Card on homepage

πŸ“Έ Screenshot

image

@petertgiles petertgiles linked an issue Oct 23, 2024 that may be closed by this pull request
4 tasks
@yonikid15 yonikid15 self-requested a review October 25, 2024 14:07
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amaze-za-ing ⭐, just a few small tweaks left.

Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man we almost forgot adding the SEO component πŸ˜†

      <SEO
        title={intl.formatMessage(pageTitle)}
        description={intl.formatMessage(pageSubtitle)}
      />

Screenshot from 2024-10-25 15-18-44

@petertgiles
Copy link
Contributor Author

Oh wow, good catch!
add seo component

Guess I'll post a bug issue for the directive page, too. 😬

Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ New card on homepage for IT training fund ✨ New IT Training Fund static page
2 participants