Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Notifications page #9755

Merged
merged 28 commits into from
Mar 20, 2024
Merged

[Feature] Notifications page #9755

merged 28 commits into from
Mar 20, 2024

Conversation

esizer
Copy link
Member

@esizer esizer commented Mar 14, 2024

πŸ€– Resolves #9558

πŸ‘‹ Introduction

Adds a page to view notifications for the logged in user.

πŸ•΅οΈ Details

I opted to use links for the "load more" and "unread/all" actions so we can sync with URL. This means you can navigate to the following URLs to get the list:

  • /applicant/notifications?unread
  • /applicant/notifications?page=2

Also, this means the back button should restore state if you click a notification and then the back button.

Some things to consider when reviewing:

  • Design does not match exactly because the files are ahead of where the code is at right now. More specifically:
    • Header/Hero
    • Sidebar width
    • Buttons in dropdown are underlined (built into button) but not in design
    • Missing the pinning and filters (being done in another ticket not yet created)

πŸ§ͺ Testing

In order to set this up (seed notifications) I found it easy to login as admin admin@test.com and then go to that users user information page, add them to a pool and just change the status over and over until you feel like you have enough πŸ€·β€β™€οΈ

  1. Build npm run dev
  2. Login
  3. Navigatge to /en/applicant/notifications
  4. Confirm notifications appear and match the mockup
  5. Test mutations
    • Marking as read
    • Marking as unread
    • Deleting
    • Marking all as read
  6. Click on a notification
  7. Confirm it takes you to the application
  8. Confirm that notification is now marked as read
  9. Confirm load more appends to the list
  10. Confirm load more button disappears when all notifications are loaded
  11. Confirm switching the tab from "All" to "Unread" updates the list as expected

πŸ“Έ Screenshot

localhost_8000_en_applicant_notifications (1)
localhost_8000_en_applicant_notifications

@petertgiles petertgiles self-requested a review March 15, 2024 12:52
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, this is cool. 😎 I flagged a few things to check on.

@esizer esizer requested a review from petertgiles March 15, 2024 18:45
@esizer esizer added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit d37076e Mar 20, 2024
10 checks passed
@esizer esizer deleted the 9558-notifications-page branch March 20, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ All notifications page
4 participants