-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] handle null state for SkillLevel on screening decision dialog #9773
Conversation
Co-authored-by: Matt <mnigh@users.noreply.github.com>
Co-authored-by: Matt <mnigh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated a pool to not have
|
I'm able to reproduce the error when I wipe out the existing required level and replace it with empty string. Currently in prod all existing processes have NULL in their requiredLevel column. Let me know what do you think on that. |
let title = ""; | ||
const skillLevel = getSkillLevelMessage(poolSkill, intl); | ||
if (!isEmpty(skillLevel)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops ..looks like I have put back the old code during merge conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! π
π€ Resolves #9757
π Introduction
This PR omits
Not Found
key word when there is no required level for the skill on the screening decision dialog title and inside the description sectionπ΅οΈ Details
Add any additional details that could assist with reviewing or testing this PR.
π§ͺ Testing
Assist reviewers with steps they can take to test that the PR does what it says it does.
To assess
for any candidate to open up the screening decision dialogNot Found
doesn't appear in the dialogRegression Test
To assess
for any candidate to open up the screening decision dialogπΈ Screenshot
When there is no required level
When there is required level