[Bug] handle null state for SkillLevel on screening decision dialog

[brindasasi]

🤖 Resolves #9757

👋 Introduction

This PR omits Not Found key word when there is no required level for the skill on the screening decision dialog title and inside the description section

🕵️ Details

Add any additional details that could assist with reviewing or testing this PR.

🧪 Testing

Assist reviewers with steps they can take to test that the PR does what it says it does.

1. Open any existing process without required level on the skills ( make sure candidates exist)
2. Go to screening and assessment tab
3. Click on To assess for any candidate to open up the screening decision dialog
4. Verify Not Found doesn't appear in the dialog

Regression Test

1. Open any existing process WITH required level on the skills ( make sure candidates exist)
2. Go to screening and assessment tab
3. Click on To assess for any candidate to open up the screening decision dialog
4. Verify Skill Levels are appearing properly for the Title and the description of the dialog.

📸 Screenshot

When there is no required level

When there is required level

[esizer]

Tried reviewing this but actually got a 500 from the API 😢

[brindasasi]

Tried reviewing this but actually got a 500 from the API 😢

how did you get this error ? 🤔 It works fine for me

[esizer]

how did you get this error ? 🤔 It works fine for me

I just updated a pool to not have required_level like the first step suggested 😅

Open any existing process without required level on the skills

[brindasasi]

how did you get this error ? 🤔 It works fine for me

I just updated a pool to not have required_level like the first step suggested 😅

Open any existing process without required level on the skills

I'm able to reproduce the error when I wipe out the existing required level and replace it with empty string.
The reason is that PoolCandidateSnapshot query couldn't parse the empty string into enum.
I don't think anyone would be able to add empty string for the Required Level via UI and not a valid use case IMO.

Currently in prod all existing processes have NULL in their requiredLevel column.
Similarly when I wipe out the required level column in my local and leave it as NULL, the fix works fine.

Let me know what do you think on that.

[vd1992]

Works... Partially

[vd1992]

getSkillLevelMessage() will never fail the check as it returns a truthy string guaranteed, it either returns a skill level or the fallback notFound

[brindasasi]

Oops ..looks like I have put back the old code during merge conflict.

[vd1992]

Looks good!

[esizer]

LGTM! 👍

stale