This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Bugfix: Presenter not destroyed when Fragment is popped off the backstack#78

Merged

StefMa merged 83 commits intomasterfrom bugfix/fragment_backstack_presenter_not_destroyed

Apr 25, 2017

+5,624-1,037

Commits on Mar 10, 2017

Adds a TiFragmentDelegateBuilder.
Robert Berghegger
committed

Commits on Mar 12, 2017

Changes the visibility of the SAVED_PRESENTER_ID class variable in the TiFragmentDelegate class.
Robert Berghegger
committed
Adds a TiFragmentPresenterDestroyTest class with a first test implementation.
Robert Berghegger
committed

Commits on Mar 15, 2017

Merge branch 'master' into bugfix/fragment_backstack_presenter_not_destroyed
Pascal Welsch
committed
Inject savior with fragment delegate builder
Pascal Welsch
committed

Commits on Mar 16, 2017

Adds more tests to the TiFragmentPresenterDestroyTest class.
Robert Berghegger
committed
Refactors method names in the TiFragmentDelegateBuilder class.
Robert Berghegger
committed
Changes the back stack test case.
Robert Berghegger
committed

Commits on Mar 17, 2017

Adds a fragment lifecycle test to the sample application.
Robert Berghegger
committed
Logs delegate method callbacks in the TestFragment.
Robert Berghegger
committed

Commits on Mar 20, 2017

Changes tests according to the real Fragment lifecycle.
Robert Berghegger
committed
Adds more tests to the TiFragmentPresenterDestroyTest.
Robert Berghegger
committed
Change name of sample app
Pascal Welsch
committed
Add all test cases stubs
Pascal Welsch
committed
Moves the basic Bundle initialization into the setUp() method of the test class for all methods that don’t require the PutInMapAnswer.
Robert Berghegger
committed
Logs if onCreate_afterSuper should be called with null or with a non null Bundle.
Robert Berghegger
committed
Adds an option to retain a fragment instance in the FragmentLifecycleActivity.
Robert Berghegger
committed
Improves logging in the TestFragment.
Robert Berghegger
committed
Implements all tests for the combination savior = false and retain = false.
Robert Berghegger
committed
Fixes false test implementations.
Robert Berghegger
committed
Add HostingActivity which can change it’s state of isChangingConfigurations() and isFinishing() in tests
Pascal Welsch
committed

Commits on Mar 22, 2017

Fixes test cases so they only test the scope that is implied by the test name.
Robert Berghegger
committed
Adds more test case implementations.
Robert Berghegger
committed
Adds missing test implementations.
Robert Berghegger
committed
Improve logging
Pascal Welsch
committed
Splits the tests into multiple files.
Robert Berghegger
committed
Adds more missing test cases.
Robert Berghegger
committed
Adds more missing test cases.
Robert Berghegger
committed
Implement equals correctly for the configuration
Pascal Welsch
committed
Add more logging
Pascal Welsch
committed
Verified and improved the single fragment default cases
Pascal Welsch
committed
Verify retain false tests with savior true for single fragments
Pascal Welsch
committed
Improve logging
Pascal Welsch
committed
Verify dontKeepActivitiesFalse_activityFinishing tests
Pascal Welsch
committed
Verify saviorFalse_retainFalse_dontKeepActivitiesFalse_activityChangingConfiguration
Pascal Welsch
committed
Adjust comments and rename HostingActivity reset function
Pascal Welsch
committed
Verify first dontKeepActivitiesFalse cases
Pascal Welsch
committed
Finish verifying Single Fragment cases
Pascal Welsch
committed
Add moveToBackground_moveToForeground tests
Pascal Welsch
committed

Commits on Mar 23, 2017

Add more move to background -> foreground cases
Pascal Welsch
committed
Add more move to background -> foreground cases
Pascal Welsch
committed
Finalize moveToBackground -> moveToForeground tests
Pascal Welsch
committed
Mark default cases for muti fragment tests
Pascal Welsch
committed
Rename “Default case” to “Default config”
Pascal Welsch
committed

Commits on Mar 24, 2017

Changes code formatting.
Robert Berghegger
committed

Commits on Apr 13, 2017

Allow removing FragmentA
Pascal Welsch
committed
Move don’t keep Activities cases to a sparate file
Pascal Welsch
committed

Commits on Apr 16, 2017

Merge branch 'master' into bugfix/fragment_backstack_presenter_not_destroyed
Pascal Welsch
committed
Remove verification comments because all test have to be rechecked anyways :D
Pascal Welsch
committed
Future TiFragments use the savior or don’t retain. savior false but retain true will be invalid
Pascal Welsch
committed

Commits on Apr 17, 2017

Allow set Fragment#isRemoving in tests
Pascal Welsch
committed
Add don’t keep activities tests
Pascal Welsch
committed
Remove savior=false tests, savior false is deprecated
Pascal Welsch
committed

Commits on Apr 18, 2017

Finish all current fragment tests
Pascal Welsch
committed
Also remove static savior setting in Activity
Pascal Welsch
committed
Observe activity scopes and destory presenters accordingly
Pascal Welsch
committed
Make PresenterSavior testable
Pascal Welsch
committed
Fix recursive call
Pascal Welsch
committed
Remove deprecated android tests, replaced with far better jvm tests
Pascal Welsch
committed

Commits on Apr 19, 2017

Harden providePresenter() to only return INITIALIZED state instances
Pascal Welsch
committed
Print the current presenter state when failing
Pascal Welsch
committed
Create a new Presenter when the Presenter is destroyed
Pascal Welsch
committed

Commits on Apr 21, 2017

Extract ActivityLifecycleCallbacks to a separate class
Pascal Welsch
committed
Move methods for testing to a TestPresenterSavior class
Pascal Welsch
committed

Commits on Apr 23, 2017

Make fragment presenter retain adjustable
Pascal Welsch
committed
Add mulitple variants for the previous presenter leaking case
Pascal Welsch
committed
Test to reuse of fragments
Pascal Welsch
committed
Remove todo which is now done
Pascal Welsch
committed
Cleanup logging
Pascal Welsch
committed
Remove all deprecated usages of setUseStaticSaviorToRetain()
Pascal Welsch
committed
Add documentation
Pascal Welsch
committed
Don’t allow the usage of setRetainInstance(true)
Pascal Welsch
committed

Commits on Apr 24, 2017

Simplify destroy logic in TiFragment and TiActivity
Pascal Welsch
committed
Rename isInBackstack -> isFragmentInBackstack
Pascal Welsch
committed
Improve providePresenter documentation
Pascal Welsch
committed

Commits on Apr 25, 2017

Remove unused class (was moved to sample)
Pascal Welsch
committed
Review improvements
Pascal Welsch
committed
Add detach/attach feature to sample
Pascal Welsch
committed
Don’t print a hint as warning
Pascal Welsch
committed
Use same visibility for Listener as the using class
Pascal Welsch
committed
Add sample/test for viewpager
StefMa
committed
Better starting of Activities
StefMa
committed
Merge pull request #84 from StefMa/bugfix/fragment_backstack_presenter_not_destroyed
passsy
authored