Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Tag 컴포넌트 구현 #132

Merged
merged 4 commits into from
Aug 12, 2024
Merged

[Feat]: Tag 컴포넌트 구현 #132

merged 4 commits into from
Aug 12, 2024

Conversation

SeieunYoo
Copy link
Collaborator

@SeieunYoo SeieunYoo commented Aug 10, 2024 •
edited
Loading

🎉 변경 사항

  • tag 컴포넌트를 구현합니다.
  • 스토리북도 추가합니다.

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

  • tag 컴포넌트 만들면서 시맨틱 컬러 토큰이 추가되어서 같이 반영합니다.

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-bihquoawmk.chromatic.com/

@SeieunYoo SeieunYoo changed the title [Feat] Tag 컴포넌트 구현 [Feat]: Tag 컴포넌트 구현 Aug 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-nfkkzvzyfk.chromatic.com/

eugene028
eugene028 reviewed Aug 11, 2024
View reviewed changes
Copy link
Collaborator

@eugene028 eugene028 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 작업 감사합니다..! 다만 스토리북에서 확인하여 보았을 때 몇가지 스타일이 제대로 적용이 안되어 있는 것 같아서 요 부분 확인 한번 부탁드릴게용용!! 😁
wow-docs에서는 잘 나오는데 스토리북에서 안먹는게 이상하네융

  1. Padding

스크린샷 2024-08-12 오전 12 43 03

  1. BackgroundColor
스크린샷 2024-08-12 오전 12 45 41

eugene028
eugene028 reviewed Aug 11, 2024
View reviewed changes
packages/wow-ui/src/components/Tag/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Tag/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Tag/index.tsx Outdated Show resolved Hide resolved
ghdtjgus76
ghdtjgus76 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 저는 스토리북 상에서 패딩 값이나 스타일 잘 적용된 걸로 보이긴 합니다!

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-qywwftdrtn.chromatic.com/

@SeieunYoo
Copy link
Collaborator Author

헉 크로마틱으로 배포된 스토리북에서 잘 안보이시는 걸까요?! 저도 아래처럼 잘 보이곤 있긴 합니다..😥
image

@eugene028
Copy link
Collaborator

eugene028 commented Aug 12, 2024 •
edited
Loading

흠 이거 제 문제인거 같아서 일단 어푸룹 하겠습동 (크로마틱 배포한건 잘보여용)

@SeieunYoo SeieunYoo merged commit f880aa6 into main Aug 12, 2024
3 checks passed
@SeieunYoo SeieunYoo deleted the feature/tag-component branch August 12, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@eugene028 eugene028 eugene028 approved these changes

@hamo-o hamo-o Awaiting requested review from hamo-o hamo-o is a code owner

Assignees

@SeieunYoo SeieunYoo

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Tag 컴포넌트 구현
3 participants
@SeieunYoo @eugene028 @ghdtjgus76