Tweak density plotting function #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the lattice mismatch between Volume and Structure, change Structure to optional argument, create structure coords using Volume
stefsmeets
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Thanks, looks good! I made a few small changes to the code.
I think it is best if we avoid mixing structure/volume lattices inside this function. I think it breaks any 'normal' usage of this plotting function. It's better to make this manipulation outside expicitly, not to have any surprises when the lattices are very different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#160
Fix the lattice mismatch between Volume and Structure, change Structure to optional argument, create structure coords using Volume, make equal sites same color