Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional argument to gemdash, to specify trajectory location #214

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

v1kko
Copy link
Contributor

@v1kko v1kko commented Nov 27, 2023

This pull request adds the optional --file [FILE] argument to gemdash

@v1kko v1kko requested a review from AstyLavrinenko November 27, 2023 12:53
@v1kko
Copy link
Contributor Author

v1kko commented Nov 27, 2023

Hi @AstyLavrinenko can you test this branch on Windows to check if it works?

@v1kko v1kko linked an issue Nov 27, 2023 that may be closed by this pull request
@AstyLavrinenko
Copy link
Contributor

Hi @AstyLavrinenko can you test this branch on Windows to check if it works?

Hi Victor, I checked. I can open the dashboard without specifying the path to the vasprun file. However, when the dashboard is open, I cannot select or change the file path. Inserting the path directly doesn't work either. Also It seems I need to open a new dashboard if I want to switch to a different vasprun file since changing the path in the open window failed.

@v1kko
Copy link
Contributor Author

v1kko commented Dec 1, 2023

I am not able to reproduce such an issue. The only time I cannot adjust the path is when I stop gemdash on the commandline, then the boxes in the dashboard get grayed out. However if I restart gemdash again (even with a different --file <vasprun.xml path>) it becomes selectable again. (provided that it servers the dashboard on the same location, http://localhost:8501 for example.)

Can you share a step by step example of how you use it when you encounter the issue?
Something like:

  • Start gemdash -f simulation1/vasprun.xml, running on http://localhost:8501
  • Open browser at http://localhost:8501
  • Stop gemdash
  • Start gemdash -f simulation2/vasprun.xml, running on http://localhost:8501
  • Issue while changing path in first browser!

@v1kko
Copy link
Contributor Author

v1kko commented Dec 5, 2023

I am merging this now, if there are still issues, we can take care of them via a new issue/pull request

@v1kko v1kko merged commit cff438c into main Dec 5, 2023
3 checks passed
@v1kko v1kko deleted the dash_arg branch December 5, 2023 15:30
@AstyLavrinenko
Copy link
Contributor

Hi @v1kko
Sorry for the late reply—it's been a bit of a crazy few weeks on my end. I just checked the dashboard installed locally from a new repo. It worked, I can paste the path or change it directly in the browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vasprun file as CLI parameter to gemdash
2 participants