Return structure with occupancy set as Composition #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @v1kko , do you want to review this one? |
4 tasks
v1kko
requested changes
Jan 24, 2024
Co-authored-by: Victor Azizi <victor@lipsum.eu>
Co-authored-by: Victor Azizi <victor@lipsum.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the occupancies are returned. The currently returned as a dictionary with indexes, which is inconvenient. This PR changes the return type to a Structure, with the occupancies set through the composition.
Closes #244
Todo
.split()and normal methods instead