Merge in bug fixes for Generator R-3_00_02 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reflect the kinematic variables of interest) to the KinePhaseSpace_t enum. This value labels the phase space used by QELEventGenerator when sampling kinematic variables. Add a transformation from kPSTnctnBnctl -> kPSQELEvGen in the genie::utils::kinematics::Jacobian() function, and update the LwlynSmith and Nieves cross section models so that they can compute the differential cross section in the new phase space. These changes resolve a bug in QELEventGenerator that was discovered while testing MaCCQE reweighting.
INukeHadroData2018::FracAIndep() and INukeHadroData2018::FracADep() by renormalizing the sum of the interpolated fractions to unity each time that they are calculated.
intranuke-fractions-NA2016.dat. This is intended to avoid gross interpolation problems at low energies.
idkakorin
added a commit
that referenced
this pull request
Nov 12, 2023
Merge pull request #15 from GENIE-MC/igor/FSIFixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release candidate for Generator R-3_00_02 has been tested and is ready to be merged. See document 52 on GENIE docDB for validation test results for this release.