[feat] 동적 inflate를 위한 chip 관련 구현, BreadTypeList Dto 형태 수정 및 관련 뷰 수정 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List로 전부 전환 후 기존 엔티티 삭제 예정
…hips 호출하고, 람다식 작성
jihyunniiii
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
따로 만들어서 관리하니까 확실히 코드가 깔끔해지는군요 짱짱쓰
Comment on lines
+25
to
+29
| breadTypeList = data.breadTypeList.mapNotNull { breadType -> | ||
| BreadFilterType.values().find { | ||
| it.id == breadType.breadTypeId | ||
| } | ||
| }, |
| @@ -12,3 +15,17 @@ data class Bakery( | |||
| val bakeryPicture: String, | |||
| val breadType: BreadType, | |||
| ) | |||
|
|
|||
| // TODO: 차후 네이밍 수정 | |||
| data class BakeryInformation( | |||
| @@ -75,7 +75,7 @@ class BakeryListFragment : | |||
| viewModel.bakeryListState.flowWithLifecycle(lifecycle).onEach { | |||
| when (it) { | |||
| is UiState.Success -> { | |||
| bakeryAdapter.setBakeryList(it.data.toMutableList()) | |||
| // bakeryAdapter.setBakeryList(it.data.toMutableList()) | |||
There was a problem hiding this comment.
여기 왜 주석 처리 되어있나염?????
| // 생명 주기 상태가 최소 CREATED 일 때만 수집하도록 제한 | ||
| viewModel.profileInfo.flowWithLifecycle( | ||
| viewLifecycleOwner.lifecycle, | ||
| Lifecycle.State.CREATED |
There was a problem hiding this comment.
와 핑글 때 멘토님 피드백이 이런 의미였군요 감솨합니다 ~
|
|
||
| // TODO: dana 다른 방식이 있는지 고민, 매 바인딩마다 removeAllViews 해야하는가 ? | ||
| with(binding.cgBakeryBreadTypes) { | ||
| this.removeAllViews() |
There was a problem hiding this comment.
요거 매 바인딩마다 안 하면 칩이 안 사라지는 문제가 발생하게 되나요? 재사용 때문엥?
There was a problem hiding this comment.
칩이 동적으로 바인딩되는거라서 원래 있던거에 추가로 생김요 ㅜㅜ
There was a problem hiding this comment.
무슨 방법 없을까여 근데 이게 제일 깔끔한 거 같기도,,,
jooyyoo
approved these changes
Feb 17, 2024
| @@ -12,3 +15,17 @@ data class Bakery( | |||
| val bakeryPicture: String, | |||
| val breadType: BreadType, | |||
| ) | |||
|
|
|||
| // TODO: 차후 네이밍 수정 | |||
| data class BakeryInformation( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
(관리 + 랜더링 시점에서 리스트를 만들어내는게 비효율적이라고 생각)
Screenshot 📸
나 이거 사진이 안올라감
Uncompleted Tasks 😅
To Reviewers 📢
차후에 논의