[feat] 건빵집 리스트 페이징 구현 및 리팩토링 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(건빵집 리스트에 영향을 미치는 요소들)
jihyunniiii
approved these changes
Feb 19, 2024
Comment on lines
+15
to
+30
| Pager( | ||
| config = PagingConfig( | ||
| pageSize = PAGE_SIZE, | ||
| enablePlaceholders = false, | ||
| ), | ||
| pagingSourceFactory = { | ||
| BakeryListPagingSource( | ||
| bakeryService = bakeryService, | ||
| sort = bakeryListFilterType.sortType.sortName, | ||
| personal = bakeryListFilterType.isPersonalFilterApplied == true, | ||
| isHard = bakeryListFilterType.isHard, | ||
| isBrunch = bakeryListFilterType.isBrunch, | ||
| isDessert = bakeryListFilterType.isDessert | ||
| ) | ||
| } | ||
| ).flow |
There was a problem hiding this comment.
SO 신기 ~ 페이징은 이렇게 쓰는 거군요
Comment on lines
90
to
99
| // viewModel.bakeryCategoryType.flowWithLifecycle(lifecycle).onEach { bakeryCategoryType -> | ||
| // val selectedCategory = bakeryCategoryType.entries.filter { it.value }.map { it.key } | ||
| // if (selectedCategory.isNotEmpty()) { | ||
| // AmplitudeUtils.trackEventWithProperties( | ||
| // CLICK_CATEGORY, | ||
| // CATEGORY, | ||
| // selectedCategory | ||
| // ) | ||
| // } | ||
| // }.launchIn(lifecycleScope) |
| fun fetchBakeryListPagingData(): Flow<PagingData<BakeryInformation>> { | ||
| return bakeryListPagingRepository.fetchBakeryList( | ||
| bakeryListFilterType = bakeryListFilterType.value | ||
| ).cachedIn(viewModelScope) |
# Conflicts: # app/src/main/java/com/sopt/geonppang/presentation/bakeryList/BakeryListFragment.kt # app/src/main/java/com/sopt/geonppang/presentation/bakeryList/BakeryListViewModel.kt
…o feat-bakery-list-pagination # Conflicts: # app/src/main/java/com/sopt/geonppang/presentation/bakeryList/BakeryListFragment.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
To Reviewers 📢
amplitude에 대한 로직 및 테스트 전입니다!!