Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable option in ManagedArray that uses std::vector instead of CHAI::ManagedArray #133

Closed
rrsettgast opened this issue Aug 25, 2018 · 3 comments
Assignees

Comments

@rrsettgast
Copy link
Member

Is your feature request related to a problem? Please describe.
Ben needs this so that he doesn't have conflicting version of chai when coupling ale3d to geosx.

Describe the solution you'd like
#ifdef it and it can be a compile time option.

@corbett5
Copy link
Contributor

corbett5 commented Aug 27, 2018

We talked about this before, does it need to be a std::vector, or can I just make the ChaiVector allocate it's own memory through new? The problem with simply using a std::vector instead of the ChaiVector is that it actually changes the behavior of the ManagedArray due to the copy constructor and what not.

I guess my point is if the goal is to be able to compile without chai it would be easier to make the ChaiVector just allocate it's own memory than to put a std::vector into ManagedArray.

@rrsettgast
Copy link
Member Author

The problem is that @liu15 can't have to different versions of CHAI. The version used by vista and the one used by GEOSX. So to proceed with his work, he has to use a pre-CHAI commit of GEOSX. This is obviously non-optimal.

It is your call on how to best make it work, but I would think that having ChaiVector hold a shared pointer to a std::vector would be the easiest approach.

@corbett5
Copy link
Contributor

#137

rrsettgast added a commit that referenced this issue May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants