Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to EFEM solver. #1147

Merged
merged 38 commits into from
Dec 14, 2020
Merged

Improvements to EFEM solver. #1147

merged 38 commits into from
Dec 14, 2020

Conversation

CusiniM
Copy link
Collaborator

@CusiniM CusiniM commented Sep 8, 2020 •
edited
Loading

@CusiniM CusiniM linked an issue Sep 8, 2020 that may be closed by this pull request
integratedTest Sneddon01 fails on Lassen. #1083
Closed
@CusiniM CusiniM marked this pull request as draft September 8, 2020 17:26
joshua-white
joshua-white approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@joshua-white joshua-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great cleanup.

@CusiniM CusiniM marked this pull request as ready for review October 22, 2020 22:31
@CusiniM CusiniM mentioned this pull request Nov 22, 2020
Merged
rrsettgast
rrsettgast reviewed Dec 4, 2020
View reviewed changes
src/coreComponents/mesh/EmbeddedSurfaceSubRegion.hpp
Comment on lines +283 to +308
array2d< real64 > & displacementJump()
{ return getReference< array2d< real64 > >( viewKeys.dispJump ); }

/**
* @brief Provide an immutable arrayView to the total displacement array.
* @return immutable arrayView of the total displacement array if it exists, or an error is thrown if it does not exist
* @note An error is thrown if the displacement jump does not exist
*/
arrayView2d< real64 const > displacementJump() const
{return getReference< array2d< real64 > >( viewKeys.dispJump ); }

/**
* @brief Get a mutable incremental displacement array.
* @return the incremental displacement array if it exists, or an error is thrown if it does not exist
* @note An error is thrown if the incremental displacement jump does not exist
*/
array2d< real64 > & incrementalDisplacementJump()
{ return getReference< array2d< real64 > >( viewKeys.deltaDispJump ); }

/**
* @brief Provide an immutable arrayView to the incremental displacement jump array.
* @return immutable arrayView of the incremental displacement array if it exists, or an error is thrown if it does not exist
* @note An error is thrown if the incremental displacement jump does not exist
*/
arrayView2d< real64 const > incrementalDisplacementJump() const
{ return getReference< array2d< real64 > >( viewKeys.deltaDispJump ); }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these always exist in the subregion, then can just be members.

Copy link
Collaborator Author

@CusiniM CusiniM Dec 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, they only exist for mechanics simulations. In case of flow sim they won't be registered.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the displacement jump akin to the aperture?

Copy link
Collaborator Author

@CusiniM CusiniM Dec 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is but they are two different things (separate fields). In a way the normal component of it is equal to the aperture but they are two different fields. Basically the flow solver will ask for the aperture which, in the poroelastic case is updated based on the displacement jump. It's a formality but distinguishing between them allows for a bit more flexibility, e.g., the enrichment can be done in a basis which does not use the normal to the fracture.

@CusiniM CusiniM added flag: requires rebaseline Requires rebaseline branch in integratedTests flag: requires updated submodule(s) labels Dec 11, 2020
@CusiniM CusiniM added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Dec 14, 2020
@CusiniM CusiniM merged commit 87aa554 into develop Dec 14, 2020
@CusiniM CusiniM deleted the feature/cusini1/EFEMSolvImprovements branch December 14, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-white joshua-white joshua-white approved these changes

@rrsettgast rrsettgast rrsettgast approved these changes

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

Assignees
No one assigned
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires rebaseline Requires rebaseline branch in integratedTests flag: requires updated submodule(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integratedTest Sneddon01 fails on Lassen.
3 participants
@CusiniM @rrsettgast @joshua-white