Fix potential difference calculations in molar variables #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoishamon
added
type: bug
CusiniM
approved these changes
Nov 10, 2020
klevzoff
approved these changes
Nov 19, 2020
francoishamon
added
ci: run CUDA builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the potential difference calculations in the compositional solvers (
CompositionalMultiphaseFlowandCompositionalMultiphaseWell) to make sure that we always use the phase mass densities in the gravity term. The constitutive models are also modified so that they always compute the phase mass densities, even whenuseMass = 1.I tested this PR with
deadoil_3ph_staircase_gravity_segregation_3d,co2_flux_3d, andstaircase_co2_wells_3dto make sure thatuseMass = 0anduseMass = 1produce the same results when gravity is on.Related to https://github.com/GEOSX/integratedTests/pull/106.
Fixes #1209.