Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug linking to system tpls. #1265

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Conversation

corbett5
Copy link
Contributor

No description provided.

@TotoGaz
Copy link
Contributor

TotoGaz commented Jan 11, 2021

@corbett5 I'd like to test it against GEOS-DEV/thirdPartyLibs#142
We could include the code (commented), that could be a nice test when deep modifications in the build system are made.

@corbett5
Copy link
Contributor Author

@TotoGaz I'm not sure what you mean include the code (commented), this doesn't prohibit you from using system libraries, but if you want to use them you'll have to hard-code the path, which seems pretty reasonable to me. Either way would you like me to hold off merging this until you're ready (until you approve this PR)?

@TotoGaz
Copy link
Contributor

TotoGaz commented Jan 11, 2021

I mean it could be interesting to effectively validate our script against all the system libs that are in ubuntu (e.g.). There may be some libs we have forgotten.
Furthermore, from time to time when we move our build system, uncommenting the code installing all the system libs could save us time.

@corbett5
Copy link
Contributor Author

Ahhh. Have you checked that the versions we use all have packages?

@corbett5 corbett5 merged commit 105253c into develop Jan 12, 2021
@corbett5 corbett5 deleted the bugfix/corbett/no-default-path branch January 12, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants