Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable pinned memory. #1283

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Re-enable pinned memory. #1283

merged 1 commit into from
Jan 22, 2021

Conversation

corbett5
Copy link
Contributor

Fixes testHDFFile and probably some other tests too on Lassen with the Address Translation Service disabled. Now all unit tests pass.

@wrtobin you should probably re-run at least a few benchmarks to see if this has any impact.

Related to https://github.com/GEOSX/nightlyTests/pull/5
Helps #1278

@corbett5 corbett5 merged commit 657151b into develop Jan 22, 2021
@corbett5 corbett5 deleted the corbett/enable-pinned branch January 22, 2021 18:44
@TotoGaz
Copy link
Contributor

TotoGaz commented Jan 22, 2021

@corbett5 Thx for the patch, I've coded the lines in the constructor (not surrounded by UMPIRE_ENABLE_PINNED so I'm sure they are considered).
I've just tested on Pangea3, and testPacking is now passing 🎉
But not the testHDF* 😭

I did not recompile the TPLs with the UMPIRE_ENABLE_PINNED explicitly activated since I think it is by default.
Do I need to do so?

@corbett5
Copy link
Contributor Author

@TotoGaz no it is enabled by default, I didn't recompile.

@TotoGaz
Copy link
Contributor

TotoGaz commented Jan 22, 2021

OK then, good news for testPacking, but HDF still not good 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants