Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corbett/references and exceptions #1318

Merged
merged 12 commits into from
Feb 19, 2021
Merged

Conversation

corbett5
Copy link
Contributor

@corbett5 corbett5 commented Feb 12, 2021

The first commit changes almost every function in Group and Wrapper to return / except references instead of pointers. If you look at the changes to those files there shouldn't be too much need to look at the other hundreds of files because the changes there follow directly from Group and Wrapper.

The second commit adds exceptions to key paths utilized by the python interface and adds error handling in the interface itself. Ideally the goal should be that as long as the Python user doesn't directly modify the data repository (ie completely muck up the mesh maps for example) they should not be able to crash the program. This doesn't achieve that, since I'm sure they could feed in a bunk XML file that would trigger some sort of GEOSX_ERROR that I didn't change to a GEOSX_THROW but it goes a long way in protecting them from bad command line arguments and paths to get_group and get_wrapper.

Related to
GEOS-DEV/LvArray#224
GEOS-DEV/GEOSX_PTP#24
https://github.com/GEOSX/integratedTests/pull/118

@corbett5 corbett5 force-pushed the corbett/references-and-exceptions branch from e0545c5 to 4441abd Compare February 16, 2021 21:57
@corbett5 corbett5 force-pushed the corbett/references-and-exceptions branch 2 times, most recently from 7213544 to daff0ab Compare February 18, 2021 20:06
@corbett5
Copy link
Contributor Author

Passing all but the submodule check.

@corbett5 corbett5 force-pushed the corbett/references-and-exceptions branch 2 times, most recently from 9ecbf08 to 444a4e0 Compare February 19, 2021 18:05
@corbett5 corbett5 force-pushed the corbett/references-and-exceptions branch from 444a4e0 to c9797af Compare February 19, 2021 18:55
@corbett5 corbett5 merged commit 31787b7 into develop Feb 19, 2021
@corbett5 corbett5 deleted the corbett/references-and-exceptions branch February 19, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants