-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corbett/references and exceptions #1318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrsettgast
reviewed
Feb 15, 2021
e0545c5
to
4441abd
Compare
7213544
to
daff0ab
Compare
Passing all but the submodule check. |
rrsettgast
approved these changes
Feb 19, 2021
9ecbf08
to
444a4e0
Compare
444a4e0
to
c9797af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit changes almost every function in
Group
andWrapper
to return / except references instead of pointers. If you look at the changes to those files there shouldn't be too much need to look at the other hundreds of files because the changes there follow directly fromGroup
andWrapper
.The second commit adds exceptions to key paths utilized by the python interface and adds error handling in the interface itself. Ideally the goal should be that as long as the Python user doesn't directly modify the data repository (ie completely muck up the mesh maps for example) they should not be able to crash the program. This doesn't achieve that, since I'm sure they could feed in a bunk XML file that would trigger some sort of
GEOSX_ERROR
that I didn't change to aGEOSX_THROW
but it goes a long way in protecting them from bad command line arguments and paths toget_group
andget_wrapper
.Related to
GEOS-DEV/LvArray#224
GEOS-DEV/GEOSX_PTP#24
https://github.com/GEOSX/integratedTests/pull/118