Fixed debug compilation on Lassen

[francoishamon]

This PR moves the implementation of the two MultiFluidPVTPackageWrapper::compute functions to MultiFluidPVTPackageWrapper.hpp in order to fix #1366.

Resolves #1366

[francoishamon]

Moving the two compute functions to the hpp file requires including pvt/pvt.hpp in MultiFluidPVTPackageWrapper.hpp. If I don't add PVTPackage as a dependency of physicsSolvers, then I get the error:

MultiFluidPVTPackageWrapper.hpp:25:10: fatal error: 'pvt/pvt.hpp' file not found

Apparently someone had run into the same issue before (see the deleted comment on GitHub). I spent some time trying to fix this but could not find a good solution. If someone knows how to make this works without making PVTPackage a dependency of the physicsSolvers, let me know.

[corbett5]

@bmhan12 this isn't going to make your life any easier. Sorry.

[rrsettgast]

Can't PVTPackage be a dependency of constitutive?

[francoishamon]

PVTPackage was already a dependency of constitutive:
https://github.com/GEOSX/GEOSX/blob/848d9e5e180d0bb90309704c4f8b300daa2c10be/src/coreComponents/constitutive/CMakeLists.txt#L119-L133
and this was enough when pvt/pvt.hpp was included in MultiFluidPVTPackageWrapper.cpp. Now that pvt/pvt.hpp has to be included in MultiFluidPVTPackageWrapper.hpp, it is not enough anymore, and the included file pvt/pvt.hpp cannot be found (unless PVTPackage is a also dependency of physicsSolvers).

[klevzoff]

Can't PVTPackage be a dependency of constitutive?

It already is, but constitutive isn't a dependency of physicsSolvers:
https://github.com/GEOSX/GEOSX/blob/848d9e5e180d0bb90309704c4f8b300daa2c10be/src/coreComponents/physicsSolvers/CMakeLists.txt#L111-L115

[francoishamon]

In the last commit I made physicsSolvers depend on constitutive (and as before, constitutive itself depends on PVTPackage).