Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dead code + tiny cleanings #1373

Merged
merged 11 commits into from
Mar 26, 2021
Merged

Removing dead code + tiny cleanings #1373

merged 11 commits into from
Mar 26, 2021

Conversation

TotoGaz
Copy link
Contributor

@TotoGaz TotoGaz commented Mar 26, 2021

Passing by, removing some unused code in MeshGeneratorBase.
Plus tiny typo corrections, visibility reductions, parameter reordering and forward declaration suppressions.

@TotoGaz TotoGaz requested review from francoishamon, rrsettgast and corbett5 and removed request for francoishamon March 26, 2021 03:24
Copy link
Contributor

@corbett5 corbett5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these PRs, thanks!

@TotoGaz TotoGaz merged commit 2a643ce into develop Mar 26, 2021
@TotoGaz TotoGaz deleted the feature/TotoGaz/mesh branch March 26, 2021 05:34
@TotoGaz TotoGaz mentioned this pull request Jul 6, 2021
@TotoGaz TotoGaz self-assigned this Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants