-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update host config to resolve Pangea build issue #1395
Conversation
It looks good to me, but I think the docker images will need to be rebuild. @TotoGaz would know. |
@@ -5,31 +5,31 @@ | |||
# | |||
######################################## | |||
|
|||
set( GEOSX_TPL_DIR /workrd/SCR/GEOSX/install/gcc8/GEOSX_TPL-d348871 CACHE PATH "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sytuannguyen Are these all just whitespace changes? You should fix your editor to not change lines that you don't actually touch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No he changed the MKL libraries. I think he just made the CMake syntax consistent with how we do it elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I added some spaces to make it consistent with the whole code and with itself because some space after ( and before ) are added, some are missing in these files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is lovely that GitHub choked on the non-whitespace diff...but when I said "these all just whitespace changes" I meant this file. I see the substantive diff in the other file, but non in this one.
Changing mkl libs to resolve Pangea build issue