Feature in-tree external components #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TotoGaz Could you take a look please ? |
untereiner
force-pushed
the
feature/untereiner/in-tree-plugin
branch
from
711956d to
0df98ed
Compare
untereiner
force-pushed
the
feature/untereiner/in-tree-plugin
branch
from
282b9a1 to
089c933
Compare
untereiner
force-pushed
the
feature/untereiner/in-tree-plugin
branch
from
089c933 to
4481e11
Compare
TotoGaz
approved these changes
Nov 9, 2023
rrsettgast
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
@untereiner Thanks for picking this up. I don't think anyone has used this since we ditched PAMELA and moved PVTPackage as a submodule inside the src directory. Have you confirmed that this works with an external package that is called at runtime?
| @@ -127,7 +127,7 @@ blt_append_custom_compiler_flag( FLAGS_VAR CMAKE_CXX_FLAGS | |||
| ) | |||
|
|
|||
| blt_append_custom_compiler_flag( FLAGS_VAR CMAKE_CXX_FLAGS_DEBUG | |||
| GNU "-Wno-unused-parameter -Wno-unused-variable" | |||
| GNU "-Wno-unused-parameter -Wno-unused-variable -Wno-dangling-reference" | |||
There was a problem hiding this comment.
What was this required for? i.e. where is the dangling reference that this avoids?
rrsettgast
added
ci: run CUDA builds
|
@rrsettgast Yes I confirm. I am using RESQML inputs/outputs with a kind of plugin |
Great. Thanks again. |
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
* enable in-tree external repo componenets * fix compilation of existing external component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal to solve issue #2526