-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune the hydrofrac example so that it at least runs #2763
Conversation
@@ -172,7 +175,7 @@ | |||
<FiniteVolume> | |||
<TwoPointFluxApproximation | |||
name="singlePhaseTPFA" | |||
meanPermCoefficient="1.0"/> | |||
meanPermCoefficient="0.0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot, this means using the arithmetic average?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this is the key change to make it run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this example with @zhishuaizhang in the workshop. I think we can keep the harmonic average, i.e., meanPermCoefficient="1.0"
, and a better solution I believe is to set a nonzero penaltyStiffness
(e.g., 1e12) as we have negative elementAperture
here. We may also need more Newton Iteration allowance, but it can converge now with penaltyStiffness=1e12
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok, interesting, thanks
i didn't try to change the penalty coefficient, can you share the output of that run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok, interesting, thanks
i didn't try to change the penalty coefficient, can you share the output of that run?
here it is
log.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be put back to 1.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, let me do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rrsettgast should be good to merge now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhishuaizhang please post results with meanPermCoefficient=1
solverType="gmres" | ||
preconditionerType="amg"/> | ||
preconditionerType="mgr"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah, this explains the struggle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for fixing it.
* tune the hydrofrac example ---------
* tune the hydrofrac example ---------
Trying to fix the reported issue #2632
Changes for the case to make it run without time step cuts:
After the changes, the case runs reasonably:
Does not require rebaseline since the case is not included in the integatedTests.