Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Spycher-Pruess solubility tables #2820

Merged
merged 42 commits into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
1e52dda
Include water vapourisation in CO2/Brine flash
dkachuma Nov 9, 2023
0e1ba81
Merge branch 'develop' into feature/dkachuma/co2-spycher-pruess
dkachuma Nov 9, 2023
a08dbea
Add water vapourisation table
dkachuma Nov 9, 2023
1170621
Fix compositional derivatives
dkachuma Nov 10, 2023
303682d
Add absolute tolerance to derivative check
dkachuma Nov 13, 2023
242156b
Merge branch 'develop' into feature/dkachuma/co2-spycher-pruess
dkachuma Nov 13, 2023
d001666
Use LvArray::math::abs
dkachuma Nov 13, 2023
55ff2bc
Merge branch 'feature/dkachuma/co2-spycher-pruess' of https://github.…
dkachuma Nov 13, 2023
060ebe1
Upload missing file
dkachuma Nov 13, 2023
2c5686c
Implement solubility table construction
dkachuma Nov 14, 2023
2249d58
Fix correlation units
dkachuma Nov 14, 2023
683de71
Fix units
dkachuma Nov 14, 2023
2dc23c1
Add Spycher Pruess test data
dkachuma Nov 15, 2023
b5f7ae4
Numerical derivative tests
dkachuma Nov 15, 2023
b79c039
Add PVT test data
dkachuma Nov 15, 2023
9a42867
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Nov 17, 2023
79f32aa
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Jan 4, 2024
448e0fa
Reactivate water vapourisation table
dkachuma Jan 22, 2024
377fad4
Uncomment table initialisation
dkachuma Jan 29, 2024
987aaaa
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Jan 29, 2024
3aa6b27
Merge branch 'refactor/dkachuma/test-lvarray-change' into feature/dka…
dkachuma Jan 29, 2024
dd54a97
Fix correlation parameter
dkachuma Feb 1, 2024
593c4f5
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Feb 6, 2024
eb991e5
Add checks on solubility
dkachuma Feb 7, 2024
bb78df2
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Feb 7, 2024
dfde8ed
Fix unit text
dkachuma Feb 7, 2024
16d0840
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Feb 7, 2024
39b4aa9
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Feb 9, 2024
2c49911
Rename file - prepare to copy
dkachuma Feb 9, 2024
3186273
Copy files
dkachuma Feb 9, 2024
1f35f2b
Merge commit '2c4991183d2f8ce3eef899808cb41c74fe76317f' into feature/…
dkachuma Feb 9, 2024
e06b79c
More file renaming
dkachuma Feb 9, 2024
52e87e6
Refactor table initialisation
dkachuma Mar 4, 2024
05cd474
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Mar 4, 2024
83a9a40
Fix conflicts
dkachuma Mar 4, 2024
c0bd0cb
Update src/coreComponents/constitutive/fluid/multifluid/CO2Brine/func…
dkachuma Mar 6, 2024
58a3c4e
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Mar 6, 2024
066c42b
Add comment
dkachuma Mar 7, 2024
1f20a3d
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Mar 14, 2024
b4b7d85
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
paveltomin Mar 15, 2024
590c534
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
dkachuma Mar 15, 2024
cb4cd85
Merge branch 'develop' into feature/dkachuma/spycher-pruess-solubilit…
CusiniM Mar 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreComponents/constitutive/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ set( constitutive_headers
fluid/multifluid/CO2Brine/functions/CO2Enthalpy.hpp
fluid/multifluid/CO2Brine/functions/CO2EOSSolver.hpp
fluid/multifluid/CO2Brine/functions/CO2Solubility.hpp
fluid/multifluid/CO2Brine/functions/CO2SolubilityDuanSun.hpp
fluid/multifluid/CO2Brine/functions/CO2SolubilitySpycherPruess.hpp
fluid/multifluid/CO2Brine/functions/EzrokhiBrineDensity.hpp
fluid/multifluid/CO2Brine/functions/EzrokhiBrineViscosity.hpp
Expand Down Expand Up @@ -203,6 +204,7 @@ set( constitutive_sources
fluid/multifluid/CO2Brine/functions/EzrokhiBrineDensity.cpp
fluid/multifluid/CO2Brine/functions/EzrokhiBrineViscosity.cpp
fluid/multifluid/CO2Brine/functions/CO2Solubility.cpp
fluid/multifluid/CO2Brine/functions/CO2SolubilityDuanSun.cpp
fluid/multifluid/CO2Brine/functions/CO2SolubilitySpycherPruess.cpp
fluid/multifluid/CO2Brine/functions/FenghourCO2Viscosity.cpp
fluid/multifluid/CO2Brine/functions/SpanWagnerCO2Density.cpp
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,10 @@ void CO2BrineFluid< PHASE1, PHASE2, FLASH >::createPVTModels()
// If 1 table is provided, it is the CO2 solubility table and water vapourisation is zero
// If 2 tables are provided, they are the CO2 solubility and water vapourisation tables depending
// on how phaseNames is arranged
string const solubilityModel = EnumStrings< CO2Solubility::SolubilityModel >::toString( CO2Solubility::SolubilityModel::Tables );
string_array strs;
strs.emplace_back( "FlashModel" );
strs.emplace_back( "Tables" ); // Marker to indicate that tables are provided
strs.emplace_back( solubilityModel ); // Marker to indicate that tables are provided
strs.emplace_back( "" ); // 2 empty strings for the 2 phase tables gas first, then water
strs.emplace_back( "" );
if( m_solubilityTables.size() == 2 )
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ class CO2BrineFluid : public MultiFluidBase

// Flash model
std::unique_ptr< FLASH > m_flash;

};

// these aliases are useful in constitutive dispatch
Expand Down
Loading
Loading