Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time step cut support for sequential solver #2861

Merged
merged 27 commits into from
Dec 21, 2023
Merged

Time step cut support for sequential solver #2861

merged 27 commits into from
Dec 21, 2023

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Nov 30, 2023 •
edited
Loading

Currently the simulation would stop if outer loop didn't converge. This PR adds time step cut logic.
Bonus:

  • print next dt in sub-timestepping process
  • add setNextDtBasedOnNewtonIter for coupled solver to avoid subsolvers doing a lot of iters
  • when pressure change is computed - switch from relative to absolute for pres < 1

@paveltomin paveltomin self-assigned this Nov 30, 2023
@paveltomin paveltomin linked an issue Nov 30, 2023 that may be closed by this pull request
Sequential solver does not support time step cut #2858
Closed
@paveltomin paveltomin added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Dec 1, 2023
@paveltomin paveltomin added ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline and removed flag: requires rebaseline Requires rebaseline branch in integratedTests labels Dec 12, 2023
@paveltomin
Copy link
Contributor Author

tests are ok, does not need rebaseline

@paveltomin paveltomin removed the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 20, 2023
@jhuang2601 jhuang2601 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Dec 20, 2023
@paveltomin paveltomin added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 21, 2023
@TotoGaz TotoGaz merged commit 39e75de into develop Dec 21, 2023
@TotoGaz TotoGaz deleted the pt/seq-ts-cut branch December 21, 2023 06:15
ouassimkh pushed a commit that referenced this pull request Feb 16, 2024
@paveltomin @ouassimkh
Time step cut support for sequential solver (#2861)
3806365 
Currently the simulation would stop if outer loop didn't converge. This commit adds time step cut logic.
Bonus:
- print next dt in sub-timestepping process
- add `setNextDtBasedOnNewtonIter` for coupled solver to avoid subsolvers doing a lot of iters
- when pressure change is computed - switch from relative to absolute for pres < 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@joshua-white joshua-white Awaiting requested review from joshua-white

Assignees

@paveltomin paveltomin

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sequential solver does not support time step cut
3 participants
@paveltomin @jhuang2601 @TotoGaz