Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minCompDens #2889

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Fix minCompDens #2889

merged 3 commits into from
Dec 15, 2023
+3 −2

Conversation

victorapm
Copy link
Contributor

Fix use of minCompDens inside chopNegativeDensities kernel

@victorapm victorapm self-assigned this Dec 12, 2023
@victorapm victorapm added type: bug Something isn't working flag: ready for review labels Dec 12, 2023
@victorapm victorapm linked an issue Dec 12, 2023 that may be closed by this pull request
Running GPU GEOS on one node with 8 X 80GB A100 GPUs generates Umpire failures #2867
Closed
jhuang2601
jhuang2601 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this fix.
I've reran the SEAM CO2 case with this branch and GPU compilation on Cypress.
Now, the reported issue umpire::runtime_error is gone and case can be running.

@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI and removed flag: ready for review labels Dec 14, 2023
@TotoGaz
Copy link
Contributor

TotoGaz commented Dec 14, 2023

No need to rebaseline

    Status     : TestCase                              : Directory                                                 : Elapsed : Resources : TestStep  
    ---------- : ------------------------------------- : --------------------------------------------------------- : ------- : --------- : ----------
    FAIL CHECK : PoroElastic_permeableFault_smoke_01   : poroElasticCoupling/PoroElastic_permeableFault_smoke_01   : 0:00:05 : 0:00:05   : restartcheck
    FAIL CHECK : PoroElastic_impermeableFault_smoke_01 : poroElasticCoupling/PoroElastic_impermeableFault_smoke_01 : 0:00:05 : 0:00:05   : restartcheck
    ---------- : ------------------------------------- : --------------------------------------------------------- : ------- : --------- : ----------

@TotoGaz TotoGaz added flag: no rebaseline Does not require rebaseline and removed ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 14, 2023
@TotoGaz TotoGaz merged commit 2017843 into develop Dec 15, 2023
@TotoGaz TotoGaz deleted the feature/paludettomag1/fix-minCompDens branch December 15, 2023 03:30
ouassimkh pushed a commit that referenced this pull request Feb 16, 2024
@victorapm @ouassimkh
Fix use of minCompDens inside chopNegativeDensities kernel (#2889)
3b09628 
Fix use of minCompDens inside chopNegativeDensities kernel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paveltomin paveltomin paveltomin approved these changes

@wrtobin wrtobin wrtobin approved these changes

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast

Assignees

@victorapm victorapm

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: no rebaseline Does not require rebaseline type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running GPU GEOS on one node with 8 X 80GB A100 GPUs generates Umpire failures
5 participants
@victorapm @TotoGaz @paveltomin @wrtobin @jhuang2601