Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests on GPU CI platform. #2985

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Conversation

rrsettgast
Copy link
Member

@rrsettgast rrsettgast commented Feb 9, 2024

unit tests are now being executed on a GPU enabled runner. Two tests are failing. I turned them off in develop and have reenabled them in this PR. They need to be fixed asap. Then we can move to the integratedTests on a GPU runner.

@rrsettgast rrsettgast added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.69%. Comparing base (bb72b14) to head (39b4f25).
Report is 101 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2985   +/-   ##
========================================
  Coverage    55.68%   55.69%           
========================================
  Files         1032     1032           
  Lines        87740    87740           
========================================
+ Hits         48861    48863    +2     
+ Misses       38879    38877    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rrsettgast rrsettgast changed the title Fix unit test on GPU CI platform. Fix unit tests on GPU CI platform. Feb 12, 2024
@rrsettgast rrsettgast requested a review from wrtobin February 12, 2024 20:06
@sframba
Copy link
Contributor

sframba commented Apr 9, 2024

@rrsettgast testLifoStorage should be ok now, @jiemeng-total pushed her fix into this branch

@rrsettgast rrsettgast added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Jun 24, 2024
@rrsettgast rrsettgast requested a review from CusiniM June 24, 2024 22:15
@rrsettgast rrsettgast merged commit 07e096e into develop Jun 25, 2024
26 checks passed
@rrsettgast rrsettgast deleted the bugfix/fixUnitTestsOnGPU branch June 25, 2024 04:34
Algiane pushed a commit that referenced this pull request Jul 30, 2024
* re-enable testLifoStorage
* adding fix for unit test testLifoStorage

Co-authored-by: Jie Meng <jie.meng@total.com>
Co-authored-by: Stefano Frambati <stefano.frambati@totalenergies.com>
Co-authored-by: j0405284 <stefano.frambati@total.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants