-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests on GPU CI platform. #2985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2985 +/- ##
========================================
Coverage 55.68% 55.69%
========================================
Files 1032 1032
Lines 87740 87740
========================================
+ Hits 48861 48863 +2
+ Misses 38879 38877 -2 ☔ View full report in Codecov by Sentry. |
rrsettgast
changed the title
Fix unit test on GPU CI platform.
Fix unit tests on GPU CI platform.
Feb 12, 2024
@rrsettgast |
rrsettgast
added
the
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
label
Jun 24, 2024
CusiniM
approved these changes
Jun 25, 2024
Algiane
pushed a commit
that referenced
this pull request
Jul 30, 2024
* re-enable testLifoStorage * adding fix for unit test testLifoStorage Co-authored-by: Jie Meng <jie.meng@total.com> Co-authored-by: Stefano Frambati <stefano.frambati@totalenergies.com> Co-authored-by: j0405284 <stefano.frambati@total.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests are now being executed on a GPU enabled runner. Two tests are failing. I turned them off in
develop
and have reenabled them in this PR. They need to be fixed asap. Then we can move to the integratedTests on a GPU runner.testLifoStorage
@sframba If not you, then can you assign someone on your team?testExternalSolvers
@castelletto1 @CusiniM