Fix tutorial example for thermal debonding wellbore problem #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuang2601
added
flag: ready for review
ci: run CUDA builds
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3170 +/- ##
========================================
Coverage 55.71% 55.71%
========================================
Files 1031 1031
Lines 87698 87698
========================================
Hits 48863 48863
Misses 38835 38835 ☔ View full report in Codecov by Sentry. |
|
jhuang2601
added
the
flag: requires rebaseline
sytuannguyen
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Very good fix, there still a little difference in the last figure (red curves) however this fix sound very good. I am just not ok with the term "no debonding" in the legends of the first figure. Indeed, these results are for the case with debonding as we can see the displacement jump at r approx 0.21 m
sytuannguyen
approved these changes
Jun 17, 2024
Algiane
pushed a commit
that referenced
this pull request
Jun 21, 2024
Algiane
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR fixes the reported issue (#3169).
It should be merged after #3133.