Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Taper Layers in wave solvers #3224

Open
wants to merge 92 commits into
base: develop
Choose a base branch
from

Conversation

acitrain
Copy link
Contributor

@acitrain acitrain commented Jul 12, 2024

This PR add a first version of Taper layers for wave solvers
These layers are set to improve the efficiency of absoption of boundaries.
This is how the version version works:

  • We compute a taper profile which is equal to one when you are outside the taper layers and to :
    $d_x = \displaystyle \frac{-3V_{max}}{2L}log(R)(\frac{x}{L})^2$ where $V_{max}$ is the maximum P-wavespeed, L the length of the taper layer and R the reflectivitity coeff (which is between $10^{-3}$ and $10^{-6}$
  • Then we multiply by the array at time n and n+1 by the taperCoeff

For this first version only second order solver contains the taper functionality and the computation of the profile as been simplified in particular in corner cases.

Those two functionalities will be add in a next PR.

acitrain added 30 commits May 2, 2024 16:53
@acitrain
Copy link
Contributor Author

acitrain commented Dec 4, 2024

Hi @rrsettgast

Could you take a look at it and approve if it seems good to you?
It is ready except integrated test but I want to do it after a code owner review

Thank you !

PS: I don't know why the docs build does not pass, it is only saying "We encountered a problem with a command while building your project. To resolve this error, double check your project configuration and installed dependencies are correct and have not changed recently."

@acitrain
Copy link
Contributor Author

@sframba @rrsettgast @CusiniM can you review this please ?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant