Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add immiscible water flash model #3237

Merged
merged 15 commits into from
Aug 29, 2024

Conversation

dkachuma
Copy link
Contributor

Implementation of an immiscible water flash model. This is a compositional model in which the water component is separated into its own (third) phase and doesn't take part in the negative two phase flash. This is similar in implementation to the BlackOilFluid.

@dkachuma dkachuma self-assigned this Jul 23, 2024
@dkachuma dkachuma marked this pull request as ready for review July 23, 2024 05:06
@dkachuma dkachuma changed the title Add immiscible water flash model feat: Add immiscible water flash model Jul 23, 2024
@dkachuma dkachuma added the type: feature New feature or request label Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 94.24779% with 13 lines in your changes missing coverage. Please review.

Project coverage is 56.56%. Comparing base (42966e9) to head (5094fc9).
Report is 89 commits behind head on develop.

Files with missing lines Patch % Lines
...compositional/models/ImmiscibleWaterParameters.cpp 59.09% 9 Missing ⚠️
...compositional/models/ImmiscibleWaterFlashModel.cpp 93.33% 2 Missing ⚠️
...compositional/models/ImmiscibleWaterFlashModel.hpp 94.87% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3237      +/-   ##
===========================================
+ Coverage    56.46%   56.56%   +0.10%     
===========================================
  Files         1059     1064       +5     
  Lines        89458    89682     +224     
===========================================
+ Hits         50512    50730     +218     
- Misses       38946    38952       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkachuma dkachuma requested a review from paveltomin August 8, 2024 15:15
@dkachuma dkachuma requested a review from joshua-white as a code owner August 9, 2024 15:29
@dkachuma dkachuma added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Aug 13, 2024
@dkachuma dkachuma added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Aug 26, 2024
@dkachuma dkachuma mentioned this pull request Aug 28, 2024
24 tasks
@rrsettgast rrsettgast merged commit 1b250bb into develop Aug 29, 2024
22 checks passed
@rrsettgast rrsettgast deleted the feature/dkachuma/immiscible-water-model branch August 29, 2024 05:00
rrsettgast pushed a commit that referenced this pull request Sep 17, 2024
* Add immiscible water flash model
rrsettgast pushed a commit that referenced this pull request Sep 17, 2024
* Add immiscible water flash model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants