-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add immiscible water flash model #3237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkachuma
changed the title
Add immiscible water flash model
feat: Add immiscible water flash model
Jul 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3237 +/- ##
===========================================
+ Coverage 56.46% 56.56% +0.10%
===========================================
Files 1059 1064 +5
Lines 89458 89682 +224
===========================================
+ Hits 50512 50730 +218
- Misses 38946 38952 +6 ☔ View full report in Codecov by Sentry. |
paveltomin
approved these changes
Aug 9, 2024
dkachuma
added
the
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
label
Aug 26, 2024
rrsettgast
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Add immiscible water flash model
rrsettgast
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Add immiscible water flash model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: ready for review
type: feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of an immiscible water flash model. This is a compositional model in which the water component is separated into its own (third) phase and doesn't take part in the negative two phase flash. This is similar in implementation to the
BlackOilFluid
.