feat: Add immiscible multiphase flow package #3251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CusiniM
commented
Jul 30, 2024
src/coreComponents/physicsSolvers/fluidFlow/ImmiscibleMultiphaseFlowFields.hpp
Outdated
Show resolved
Hide resolved
CusiniM
commented
Jul 30, 2024
src/coreComponents/physicsSolvers/fluidFlow/ImmiscibleMultiphaseFlowFields.hpp
Outdated
Show resolved
Hide resolved
bd713
requested review from
rrsettgast,
corbett5,
wrtobin,
paveltomin,
klevzoff,
francoishamon,
dkachuma,
joshua-white,
MelReyCG,
cssherman and
jhuang2601
as code owners
CusiniM
commented
Sep 17, 2024
.vscode-codespaces/launch.json
Outdated
Comment on lines
12
to
13
| "program": "${userHome}/two-phase/GEOS/install-ubuntu22-debug/bin/geosx", | ||
| "args": ["-i", "/home/rpiazza/two-phase/GEOS/inputFiles/immiscibleMultiphaseFlow/immiscible_2phaseFlow_1d.xml", "-o", "${userHome}/geos-output"], |
There was a problem hiding this comment.
Remove these changes.
|
I'd remove the file |
bd713
added
the
flag: requires rebaseline
paveltomin
approved these changes
Dec 17, 2024
paveltomin
reviewed
Jan 23, 2025
| { | ||
| FlowSolverBase::registerDataOnMesh( meshBodies ); | ||
|
|
||
| // DomainPartition const & domain = this->getGroupByPath< DomainPartition >( "/Problem/domain" ); |
paveltomin
reviewed
Jan 23, 2025
|
|
||
| } ); | ||
|
|
||
| // FaceManager & faceManager = mesh.getFaceManager(); |
paveltomin
reviewed
Jan 23, 2025
| FlowSolverBase::initializePreSubGroups(); | ||
|
|
||
| DomainPartition & domain = this->getGroupByPath< DomainPartition >( "/Problem/domain" ); | ||
| // ConstitutiveManager const & cm = domain.getConstitutiveManager(); |
paveltomin
reviewed
Jan 23, 2025
| // ConstitutiveManager const & cm = domain.getConstitutiveManager(); | ||
|
|
||
| // // 1. Validate various models against each other (must have same phases and components) | ||
| // validateConstitutiveModels( domain ); |
There was a problem hiding this comment.
check and remove if not needed
paveltomin
reviewed
Jan 23, 2025
| arrayView2d< real64, immiscibleFlow::USD_PHASE > const phaseMass = subRegion.getField< fields::immiscibleMultiphaseFlow::phaseMass >(); | ||
|
|
||
| // Might be needed for geomechanics????? if so, need to change the accumulation as well? | ||
| //arrayView1d< real64 > const deltaVolume = subRegion.getField< fields::flow::deltaVolume >(); |
There was a problem hiding this comment.
this is used for geomechanics with fractures yes, see https://github.com/GEOS-DEV/GEOS/pull/3228/files#diff-44d45911b0c4b17989e2a0ba29b844cb0ee4975f16329ff612825db0b269d55b
not really needed in your PR at this point
paveltomin
reviewed
Jan 23, 2025
| // apply flux boundary conditions | ||
| applySourceFluxBC( time_n, dt, dofManager, domain, localMatrix.toViewConstSizes(), localRhs.toView() ); | ||
|
|
||
| // for( localIndex row = 0; row < localMatrix.toViewConstSizes().numRows(); ++row ) |
There was a problem hiding this comment.
remove, there is a general way to print out matrix and rhs in base solver
paveltomin
reviewed
Jan 23, 2025
| { | ||
| GEOS_MARK_FUNCTION; | ||
|
|
||
| // // Only validate BC at the beginning of Newton loop |
paveltomin
reviewed
Jan 23, 2025
| } | ||
| } ); | ||
|
|
||
| // SourceFluxStatsAggregator::forAllFluxStatWrappers( subRegion, fs.getName(), |
paveltomin
reviewed
Jan 23, 2025
| GEOS_UNUSED_VAR( dt ); | ||
|
|
||
| DofManager::CompMask pressureMask( m_numDofPerCell, 0, 1 ); | ||
| //DofManager::CompMask PhaseMask( m_numDofPerCell, 1, m_numPhases ); |
CusiniM
commented
Jan 28, 2025
| @@ -213,6 +213,7 @@ class MGRStrategyBase | |||
| #if GEOS_USE_HYPRE_DEVICE == GEOS_USE_HYPRE_CUDA || GEOS_USE_HYPRE_DEVICE == GEOS_USE_HYPRE_HIP | |||
| GEOS_LAI_CHECK_ERROR( HYPRE_BoomerAMGSetAggInterpType( solver.ptr, hypre::getAMGAggressiveInterpolationType( LinearSolverParameters::AMG::AggInterpType::modifiedExtendedE ) ) ); | |||
| GEOS_LAI_CHECK_ERROR( HYPRE_BoomerAMGSetCoarsenType( solver.ptr, hypre::getAMGCoarseningType( LinearSolverParameters::AMG::CoarseningType::PMIS ) ) ); | |||
| GEOS_LAI_CHECK_ERROR( HYPRE_BoomerAMGSetAggNumLevels( solver.ptr, 0 ) ); | |||
There was a problem hiding this comment.
can you remove this and create a PR only with this change? @victorapm we should test this. Unless you know why this would impact GPU performance so much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a multiphase immiscible solver for compressible fluids with viscous, gravity and capillary forces:
ImmiscibleMultiphaseFlowsolver and associated kernels (currently limited to two phases)TwoPhaseFluidmodel for tabular data input