ci: add the possitility to use other build generators than ninja inside the ci #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Algiane
added
ci: run CUDA builds
Algiane
force-pushed
the
feature/algiane/build-generator-option-in-ci
branch
from
b41f205 to
66ed037
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3276 +/- ##
========================================
Coverage 56.60% 56.60%
========================================
Files 1064 1064
Lines 89765 89765
========================================
Hits 50807 50807
Misses 38958 38958 ☔ View full report in Codecov by Sentry. |
Algiane
changed the title
… processes are not modified by this PR and still use Ninja generator.
…rrent ci processes are not modified by this PR and still use Ninja generator." This reverts commit 66ed037.
Modification of argument names to use those expected by the config-build script. It allows to avoid issues raised by the whitespace in the "Unix Makefiles" value previously used (the parsing done inside the github action weirdly splits the keyword on the whitespace, ignoring the use of quotes or escape (while it runs without any error in a local bash) .
Algiane
force-pushed
the
feature/algiane/build-generator-option-in-ci
branch
from
87c7fe9 to
077a1c0
Compare
This reverts commit 077a1c0.
CusiniM
approved these changes
Aug 26, 2024
4 tasks
rrsettgast
approved these changes
Sep 12, 2024
Comment on lines
41
to
42
| --eclipse | ||
| Use "Eclipse CDT4 - Unix Makefiles" as build system generator. |
Comment on lines
67
to
68
| --xcode | ||
| Use "Xcode" as build system generator. |
There was a problem hiding this comment.
It was for genericity purpose. The script can be executed outside the ci by a local docker run call so I was guessing that we may want to use one of the generators supported by the project.
But I have not tested it so ok to remove it and to focus on the ci only.
rrsettgast
added a commit
that referenced
this pull request
Sep 17, 2024
…de the ci (#3276) * Add possibility to use other build generators than ninja in ci. --------- Co-authored-by: Gaetan <gaetan.fuss.fr@gmail.com> Co-authored-by: Randolph Settgast <settgast1@llnl.gov>
rrsettgast
added a commit
that referenced
this pull request
Sep 17, 2024
…de the ci (#3276) * Add possibility to use other build generators than ninja in ci. --------- Co-authored-by: Gaetan <gaetan.fuss.fr@gmail.com> Co-authored-by: Randolph Settgast <settgast1@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR objectives
Ninjatool in the ci (smaller docker images, lighter setting)unix makefiles, notNinjaones) since errors may differ depending on the generator used (see pangea3 PR where ninja fails while make succeed)Implementation
Add the possibility to pass one of the
--ninja,--makefile,--xcodeor--eclipsecommand line arguments to theci_build_and_test_in_container.shscript. Variable names have been chosen in agreement with theconfig-build.pyscript. The--makefileoption is added to build unix makefiles.Add a
BUILD_GENERATORinput for thebuild_and_test.ymlscript.--ninjaoption is used by default to enable the Ninja generator (as it was the initial ci behaviour). The default value is used for CPU builds.Use of the
BUILD_GENERATORvalue of the GPU builds as input for thebuild_and_test.ymlcall (because I will link this PR to another one where one of the GPU build will use the unix makefile generator).Set the
BUILD_GENERATORvariable to--ninjain the matrix of GPU builds. If not explicitely provided in the matrix definition, an empty string (leading to unix makefile generation) is passed asBUILD_GENERATORinput to the build_and_test.yml scriptValidation
Commit
077a1c08bdbf5has been used to validate that for now all jobs that were usingninjastill use it and that the PR doesn't modify the ci.Fixes PR #3159 for which ninja build is broken since commit 4bef600a.