Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forgotten impacted files by PR #3278 #3288

Closed
wants to merge 3 commits into from

Conversation

MelReyCG
Copy link
Contributor

Just a quick-fix: added generated files changes & impacted exemple by the PR #3278, as I encountered the following compilation error :

/GEOS/inputFiles/singlePhaseFlowFractures/fractureFlow_conforming_2d_vtk_input.xml:26: element VTKMesh: Schemas validity error : Element 'VTKMesh', attribute 'surfacicFieldsInGEOSX': The attribute 'surfacicFieldsInGEOSX' is not allowed.
/GEOS/inputFiles/singlePhaseFlowFractures/fractureFlow_conforming_2d_vtk_input.xml fails to validate
XML validation failed. See details in xml_validation_results.log
make[2]: *** [CMakeFiles/geosx_validate_all_xml_files.dir/build.make:71: CMakeFiles/geosx_validate_all_xml_files] Error 1
make[1]: *** [CMakeFiles/Makefile2:2199: CMakeFiles/geosx_validate_all_xml_files.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

@MelReyCG MelReyCG added type: cleanup / refactor Non-functional change (NFC) flag: ready for review flag: no rebaseline Does not require rebaseline labels Aug 20, 2024
@MelReyCG MelReyCG self-assigned this Aug 20, 2024
@MelReyCG MelReyCG added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Aug 20, 2024
Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it

Comment on lines 3 to 4
<Problem xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../build-pangea4-gcc12.1-hpcxompi2.17.1-onemkl2023.2.0-release/schema.xsd">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Problem xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../build-pangea4-gcc12.1-hpcxompi2.17.1-onemkl2023.2.0-release/schema.xsd">
<Problem>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! I forgot to remove that.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.99%. Comparing base (540f606) to head (4e65b63).
Report is 88 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3288      +/-   ##
===========================================
- Coverage    56.00%   55.99%   -0.01%     
===========================================
  Files         1053     1053              
  Lines        89168    89168              
===========================================
- Hits         49935    49933       -2     
- Misses       39233    39235       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@MelReyCG MelReyCG added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Aug 21, 2024
@MelReyCG
Copy link
Contributor Author

Closed as other PRs fixed it.

@MelReyCG MelReyCG closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants