-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cleanup setMGRStrategy a bit #3422
Conversation
@victorapm this lost your review because of merging/reopening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@CusiniM, @Guotong-Ren, @castelletto1, @frankfeifan, @jhuang2601, @matteofrigo5, @rrsettgast, and/or @ryar9534 need your reviews, Victor already approved |
@CusiniM, @Guotong-Ren, @castelletto1, @frankfeifan, @jhuang2601, @matteofrigo5, @rrsettgast, and/or @ryar9534 please review |
@CusiniM, @castelletto1, @frankfeifan, @jhuang2601, @rrsettgast, and/or @ryar9534 please review, it's a simple clean up PR, nothing major |
this is reopened #3386
waiting for #3339 be merged first