Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup setMGRStrategy a bit #3422

Merged
merged 28 commits into from
Dec 13, 2024
Merged

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Nov 1, 2024

this is reopened #3386
waiting for #3339 be merged first

@paveltomin paveltomin added type: cleanup / refactor Non-functional change (NFC) flag: no rebaseline Does not require rebaseline labels Nov 1, 2024
@paveltomin paveltomin requested a review from victorapm November 1, 2024 16:36
@paveltomin paveltomin self-assigned this Nov 1, 2024
Base automatically changed from pt/wells-seq-poromech-init to develop November 6, 2024 17:52
@paveltomin
Copy link
Contributor Author

@victorapm this lost your review because of merging/reopening
could you please have another look?

Copy link
Contributor

@victorapm victorapm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@paveltomin
Copy link
Contributor Author

@CusiniM, @Guotong-Ren, @castelletto1, @frankfeifan, @jhuang2601, @matteofrigo5, @rrsettgast, and/or @ryar9534 need your reviews, Victor already approved

@paveltomin
Copy link
Contributor Author

@paveltomin
Copy link
Contributor Author

@CusiniM, @castelletto1, @frankfeifan, @jhuang2601, @rrsettgast, and/or @ryar9534 please review, it's a simple clean up PR, nothing major

@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Dec 12, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 6.75676% with 138 lines in your changes missing coverage. Please review.

Project coverage is 56.84%. Comparing base (b5ea7ce) to head (ba14408).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...sSolvers/multiphysics/SinglePhasePoromechanics.cpp 0.00% 17 Missing ⚠️
...vers/multiphysics/SinglePhaseReservoirAndWells.cpp 15.78% 16 Missing ⚠️
...csSolvers/multiphysics/MultiphasePoromechanics.cpp 0.00% 15 Missing ⚠️
...olvers/contact/SolidMechanicsEmbeddedFractures.cpp 0.00% 14 Missing ⚠️
...ysics/CompositionalMultiphaseReservoirAndWells.cpp 17.64% 14 Missing ⚠️
...sSolvers/contact/SolidMechanicsLagrangeContact.cpp 0.00% 13 Missing ⚠️
...hysicsSolvers/multiphysics/HydrofractureSolver.cpp 0.00% 10 Missing ⚠️
...cs/SinglePhasePoromechanicsConformingFractures.cpp 0.00% 9 Missing ⚠️
...sics/SinglePhasePoromechanicsEmbeddedFractures.cpp 0.00% 9 Missing ⚠️
...vers/multiphysics/CoupledReservoirAndWellsBase.hpp 44.44% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3422      +/-   ##
===========================================
- Coverage    56.89%   56.84%   -0.06%     
===========================================
  Files         1154     1154              
  Lines        99878    99954      +76     
===========================================
- Hits         56828    56818      -10     
- Misses       43050    43136      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltomin paveltomin merged commit 8497dfa into develop Dec 13, 2024
23 of 25 checks passed
@paveltomin paveltomin deleted the pt/set-mgr-strategy branch December 13, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants