fix: fix issue #2615

[paveltomin]

should close #2615

[rrsettgast]

@paveltomin
the underlying call is this:

  void getLocation( string const & key,
                    FieldLocation & location ) const
  {
    if( key.find( m_locationKeys.nodesKey() ) != string::npos )
    {
      location = FieldLocation::Node;
    }
    else if( key.find( m_locationKeys.edgesKey()) != string::npos )
    {
      location = FieldLocation::Edge;
    }
    else if( key.find( m_locationKeys.facesKey()) != string::npos )
    {
      location = FieldLocation::Face;
    }
    else if( key.find( m_locationKeys.elemsKey()) != string::npos )
    {
      location = FieldLocation::Elem;
    }
    else
    {
      GEOS_ERROR( GEOS_FMT( "Invalid key, {}, was provided. Location cannot be retrieved.", key ) );
    }
  }

which is properly guarded. The compiler is missing it for the reporting user. We can change function to return the value of location and set it explicitly in the call location. That would make more sense.

[paveltomin]

@paveltomin the underlying call is this:

  void getLocation( string const & key,
                    FieldLocation & location ) const
  {
    if( key.find( m_locationKeys.nodesKey() ) != string::npos )
    {
      location = FieldLocation::Node;
    }
    else if( key.find( m_locationKeys.edgesKey()) != string::npos )
    {
      location = FieldLocation::Edge;
    }
    else if( key.find( m_locationKeys.facesKey()) != string::npos )
    {
      location = FieldLocation::Face;
    }
    else if( key.find( m_locationKeys.elemsKey()) != string::npos )
    {
      location = FieldLocation::Elem;
    }
    else
    {
      GEOS_ERROR( GEOS_FMT( "Invalid key, {}, was provided. Location cannot be retrieved.", key ) );
    }
  }

which is properly guarded. The compiler is missing it for the reporting user. We can change function to return the value of location and set it explicitly in the call location. That would make more sense.

please check the updated version

[paveltomin]

@rrsettgast is it good now?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.89%. Comparing base (ec52431) to head (bcd0702).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3477      +/-   ##
===========================================
- Coverage    56.89%   56.89%   -0.01%     
===========================================
  Files         1154     1154              
  Lines        99873    99871       -2     
===========================================
- Hits         56825    56823       -2     
  Misses       43048    43048              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.