Feature/corbett/layouts #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrsettgast
approved these changes
Nov 6, 2019
corbett5
force-pushed
the
feature/corbett/layouts
branch
from
f2b79b0 to
0477f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look at each commit in isolation it might be easier...
The first commit adds support for the permuted arrays. It doesn't modify the integrated tests baselines and passes the tests by ignoring the element to node map.
The second commit replaces sidre with conduit passes the integrated tests because I rebased everything.
The third commit is trivial.
Depends on:
GEOSX/integratedTests#18
GEOSX/cxx-utilities#112