-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
return adj; | ||
} | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, Git is not doing a good job detecting the minimal change to the files. I thinks the whole file has changed. We may lose some history here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are line feed changes after the file has been processed by the script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @klevzoff that's what it is. Some PAMELA files still have Windows line feeds (CRLF or \r\n) and my script makes everything be LF (or \n). Maybe that's actually a good thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should definitely be standardizing line endings to LF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then I suggest we keep it like that. @joshua-white what history could we be losing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Losing history was the wrong description, more that the actual changes aren't being detected. It was good to check, but this seems fine then. I'll approve.
No description provided.