Skip to content
This repository has been archived by the owner on Jun 16, 2023. It is now read-only.

Added copyrights and notice files #41

Merged
merged 5 commits into from
Aug 24, 2020
Merged

Conversation

herve-gross
Copy link
Contributor

No description provided.

NOTICE Outdated Show resolved Hide resolved
return adj;
}

/*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, Git is not doing a good job detecting the minimal change to the files. I thinks the whole file has changed. We may lose some history here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are line feed changes after the file has been processed by the script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @klevzoff that's what it is. Some PAMELA files still have Windows line feeds (CRLF or \r\n) and my script makes everything be LF (or \n). Maybe that's actually a good thing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should definitely be standardizing line endings to LF.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then I suggest we keep it like that. @joshua-white what history could we be losing?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Losing history was the wrong description, more that the actual changes aren't being detected. It was good to check, but this seems fine then. I'll approve.

@rrsettgast rrsettgast merged commit 2e404a8 into master Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants