v4: Support for MAPL-as-library #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been requested by some of the spack-stack folks (e.g., @climbfuji) that GEOSgcm when built with Spack should be able to use MAPL as a library rather than as a component built in.
I believe this is all that is necessary. We just need to tell CMake where
mapl_stub.plis. Because MAPL is built under ecbuild, that means it has a variable calledMAPL_BASE_DIR1 that points to where MAPL is, e.g., in spack, where spack installed it.Footnotes
This is not great for MAPL since MAPL_Base is a thing for us, but, well, that's what ecbuild does. ↩