Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WMMA #59

Merged
merged 5 commits into from
Jan 26, 2024
Merged

WMMA #59

merged 5 commits into from
Jan 26, 2024

Conversation

adarmenov
Copy link
Contributor

Integrate WMMA changes into develop.

@adarmenov
Extend the functionality of DataSea
e1c4855 
This commit improves the symmetry between DataSea and 'true' ocean.
DataSea uses ExtData to provide surface currents and ocean depth.
The default configuration of DataSea does not require new datasets
and minimizes IO; currents remain set to zero (UW = VW = 0).
@adarmenov adarmenov added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs enhancement New feature or request labels Dec 20, 2023
@adarmenov adarmenov self-assigned this Dec 20, 2023
@adarmenov adarmenov requested review from a team as code owners December 20, 2023 19:27
@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, enhancement

3 similar comments
@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, enhancement

@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, enhancement

@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, enhancement

tclune
tclune previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes ok.

@adarmenov adarmenov mentioned this pull request Dec 20, 2023
Merged
sanAkel
sanAkel previously requested changes Dec 21, 2023
View reviewed changes
GEOSdatasea_GridComp/DataSea_ExtData.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, enhancement

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, enhancement

@adarmenov adarmenov requested a review from sanAkel January 5, 2024 17:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, enhancement

adarmenov
adarmenov commented Jan 10, 2024
View reviewed changes
Copy link
Contributor Author

@adarmenov adarmenov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the WGCM with the default coupled (MOM6) configuration of GEOS. My tests were done at C12 & 72 x 36. The WMMA branch was zero-diff when:

  • WGCM is not active (default)
  • WGCM/WW3 is active & feedbacks to AGCM are disabled
  • WGCM/UMWM is active & feedbacks to AGCM are disabled

@adarmenov adarmenov dismissed sanAkel’s stale review January 10, 2024 17:08

Requested changes have been addressed.

@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, enhancement

sanAkel
sanAkel approved these changes Jan 11, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@sanAkel sanAkel self-requested a review January 25, 2024 21:42
@sanAkel sanAkel removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Jan 25, 2024
@sanAkel
Copy link
Collaborator

sanAkel commented Jan 25, 2024

Someone from @GEOS-ESM/cmake-team needs to approve this PR.

@mathomp4 mathomp4 self-requested a review January 26, 2024 14:05
@sanAkel sanAkel merged commit 66c664b into develop Jan 26, 2024
9 checks passed
@sanAkel sanAkel deleted the feature/adarmenov/integrate-wmma branch January 26, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanAkel sanAkel sanAkel approved these changes

@mathomp4 mathomp4 mathomp4 approved these changes

@tclune tclune tclune left review comments

Assignees

@adarmenov adarmenov

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adarmenov @sanAkel @mathomp4 @tclune @sdrabenh